GithubHelp home page GithubHelp logo

Comments (10)

antonioru avatar antonioru commented on May 25, 2024

Hey Zach, thanks for taking the time to report this and for being a user of the library 😊

You're totally right, that issue you spotted is incorrect and it definitely needs to be fixed.
I've got a re-factoring of the TypeScript types and some better documentation in the works.
Unfortunately, I can't give you an exact release date just yet... but it's on its way!

In the meantime, if you feel up to it, open a pull request
Should be a quick and easy fix and you'll get some good karma points 😊

Thanks again for your support

from beautiful-react-hooks.

shyamtawli avatar shyamtawli commented on May 25, 2024

Hey can try to fix it?

from beautiful-react-hooks.

antonioru avatar antonioru commented on May 25, 2024

Hey can try to fix it?

you're more than welcome

from beautiful-react-hooks.

shyamtawli avatar shyamtawli commented on May 25, 2024

Hey @SirZach I have found the file, can you guide me into solving ?

from beautiful-react-hooks.

antonioru avatar antonioru commented on May 25, 2024

@shyamtawli
you just need to type the result of the useInterval hook.

Something like:

return [isCleared, clear] as [boolean, () => void]

the same problem is probably affecting useTimeout as well

from beautiful-react-hooks.

shyamtawli avatar shyamtawli commented on May 25, 2024

Thanks @antonioru for helping me. I have completed what you mentioned above for both useInterval and useTimeout.
That's it ? Should I open a PR.

from beautiful-react-hooks.

antonioru avatar antonioru commented on May 25, 2024

yes, just run the tests and build the app to make sure everything works.
If so, feel free to open the PR

from beautiful-react-hooks.

github-actions avatar github-actions commented on May 25, 2024

🎉 This issue has been resolved in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

from beautiful-react-hooks.

antonioru avatar antonioru commented on May 25, 2024

@shyamtawli well done!

from beautiful-react-hooks.

shyamtawli avatar shyamtawli commented on May 25, 2024

Thanks for helping me @antonioru
Can you share your twitter handle?

from beautiful-react-hooks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.