Comments (10)
Hey Zach, thanks for taking the time to report this and for being a user of the library 😊
You're totally right, that issue you spotted is incorrect and it definitely needs to be fixed.
I've got a re-factoring of the TypeScript types and some better documentation in the works.
Unfortunately, I can't give you an exact release date just yet... but it's on its way!
In the meantime, if you feel up to it, open a pull request
Should be a quick and easy fix and you'll get some good karma points 😊
Thanks again for your support
from beautiful-react-hooks.
Hey can try to fix it?
from beautiful-react-hooks.
Hey can try to fix it?
you're more than welcome
from beautiful-react-hooks.
Hey @SirZach I have found the file, can you guide me into solving ?
from beautiful-react-hooks.
@shyamtawli
you just need to type the result of the useInterval
hook.
Something like:
return [isCleared, clear] as [boolean, () => void]
the same problem is probably affecting useTimeout
as well
from beautiful-react-hooks.
Thanks @antonioru for helping me. I have completed what you mentioned above for both useInterval and useTimeout.
That's it ? Should I open a PR.
from beautiful-react-hooks.
yes, just run the tests and build the app to make sure everything works.
If so, feel free to open the PR
from beautiful-react-hooks.
🎉 This issue has been resolved in version 4.0.0 🎉
The release is available on:
Your semantic-release bot 📦🚀
from beautiful-react-hooks.
@shyamtawli well done!
from beautiful-react-hooks.
Thanks for helping me @antonioru
Can you share your twitter handle?
from beautiful-react-hooks.
Related Issues (20)
- The automated release is failing 🚨 HOT 2
- useGlobalEvent should check `isClient` before referencing `window` HOT 1
- Can't resolve 'react-router-dom' HOT 7
- Typing for `useTimeout` is incorrect HOT 1
- Autogenerate CHANGELOG.md
- remove index.ts from the codebase to force correct imports HOT 4
- Feature request for useSSR hook HOT 2
- useThrottledCallback doesn't consider dependencies
- Update `react-router-dom` to v6 HOT 3
- I need help about writing tests, element.scrollWidth always is 0 HOT 3
- useAudio hook can't change src when input new src HOT 2
- useLocalStorage causing infinite loops when setValue is a dependency in a useEffect HOT 2
- Remove or reduce unsupported API console warnings HOT 3
- More feature from thrid libs HOT 2
- Deprecate all react-router-dom related hooks HOT 1
- `useGeolocation` not updating state in Firefox desktop
- useAudioControls returning new controls object everytime state is updated
- :memo useWillUnmount should called useUnmount HOT 2
- Type resolution for ESM modules is broken HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from beautiful-react-hooks.