GithubHelp home page GithubHelp logo

Comments (12)

XinShuYang avatar XinShuYang commented on August 17, 2024 1

@XinShuYang you have these 2 list items:

* Recovering centOS and Photon test cases for both antrea-upgrade-matrix-compatibility-test and antrea-matrix-compatibility-test jobs based on CAPV.

* Enabling CAPA jobs for different OS such as CentOS or Photon.

I guess I do not understand how they relate to each other. If you want to enable CAPA jobs for these OS's, why do you need the first list item?

@antoninbas The final goal is to use CAPA instead of CAPV in the matrix test. However, since the PR for CAPA #5476 has not been merged yet (and I think it may take longer for review and merge), I prefer to first restore the existing CAPV jobs.

from antrea.

rajnkamr avatar rajnkamr commented on August 17, 2024

Currently Antrea matrix test wrt k8s versions with CAPA is still not merged #5476 , in case we want to move to kind based matrix testing for k8 versions, we need to streamline current CPAV matrix jobs as well !

from antrea.

XinShuYang avatar XinShuYang commented on August 17, 2024

Currently Antrea matrix test wrt k8s versions with CAPA is still not merged #5476 , in case we want to move to kind based matrix testing for k8 versions, we need to streamline current CPAV matrix jobs as well !

The current CAPV matrix job tests are based on Kubernetes v1.17.5 and v1.18.2, so I believe they have not been used for a long time. Before merging the CAPA job PR, I will first attempt to restore the necessary CAPV jobs for matrix tasks. Given that some tests can be covered by Kind testing, we can consider removing them and replacing others with CAPA afterward.

from antrea.

antoninbas avatar antoninbas commented on August 17, 2024

Overall sounds good to me.

New Kind-based periodic job will automate the testing process, eliminating the need for users to manually trigger corresponding Kind jobs during release phases.

I am not sure I agree with this statement, or maybe I am misunderstanding. We should still validate releases by running a "full" test suite, and periodic CI jobs will not change that. However, I imagine that well-monitored periodic CI jobs will reduce the amount of test failures that have to be investigated and resolved "at the last minute" during the release phase. However, historically, we haven't been good at keeping track of failures in periodic CI jobs and addressing the issues as they arise, as far as I know. Some mechanism that automatically opens a Github issue when a periodic CI job starts failing (e.g., with 2 consecutive failures) could help, but I am not sure how easy it is to set up.

from antrea.

antoninbas avatar antoninbas commented on August 17, 2024

I will first attempt to restore the necessary CAPV jobs for matrix tasks

What's the value in trying to restore / recover these old jobs before introducing the new (Kind / CAPA based) ones?

from antrea.

XinShuYang avatar XinShuYang commented on August 17, 2024

I will first attempt to restore the necessary CAPV jobs for matrix tasks

What's the value in trying to restore / recover these old jobs before introducing the new (Kind / CAPA based) ones?

There are matrix jobs validating Antrea based on CentOS and Photon OS. Do we have other running jobs that can replace them? If so, we indeed don't need to restore the CAPV matrix jobs before the CAPA upgrade.

from antrea.

XinShuYang avatar XinShuYang commented on August 17, 2024

Overall sounds good to me.

New Kind-based periodic job will automate the testing process, eliminating the need for users to manually trigger corresponding Kind jobs during release phases.

I am not sure I agree with this statement, or maybe I am misunderstanding. We should still validate releases by running a "full" test suite, and periodic CI jobs will not change that. However, I imagine that well-monitored periodic CI jobs will reduce the amount of test failures that have to be investigated and resolved "at the last minute" during the release phase. However, historically, we haven't been good at keeping track of failures in periodic CI jobs and addressing the issues as they arise, as far as I know. Some mechanism that automatically opens a Github issue when a periodic CI job starts failing (e.g., with 2 consecutive failures) could help, but I am not sure how easy it is to set up.

Yes, what I mean is periodic jobs can report failures in time. Regarding job failure notifications, the current Jenkins email notification is disabled due to the migration. I will attempt to enable it first.

from antrea.

rajnkamr avatar rajnkamr commented on August 17, 2024

I will first attempt to restore the necessary CAPV jobs for matrix tasks

What's the value in trying to restore / recover these old jobs before introducing the new (Kind / CAPA based) ones?

There are matrix jobs validating Antrea based on CentOS and Photon OS. Do we have other running jobs that can replace them? If so, we indeed don't need to restore the CAPV matrix jobs before the CAPA upgrade.

Compatibility Matrix test of antrea with k8 versions for ubuntu is taken care ( CAPA PR #5476 - non kind) , For centos and photon Antrea matrix compatibility tests, kind can be leveraged. Periodic job approach seems to save on resources which should be usually available for regular jobs.
Email notification for period job failures must be enabled for tracking of periodic jobs. May be we can add checking period job result in release checklist.

from antrea.

antoninbas avatar antoninbas commented on August 17, 2024

@XinShuYang you have these 2 list items:

  • Recovering centOS and Photon test cases for both antrea-upgrade-matrix-compatibility-test and antrea-matrix-compatibility-test jobs based on CAPV.
  • Enabling CAPA jobs for different OS such as CentOS or Photon.

I guess I do not understand how they relate to each other. If you want to enable CAPA jobs for these OS's, why do you need the first list item?

from antrea.

rajnkamr avatar rajnkamr commented on August 17, 2024

@XinShuYang
I have same question as @antoninbas , do we still want to use CAPV, we wanted to run most of the capv matrix jobs on CAPA.
It might be better to split 3rd and 4th items to different issues

"3.Introducing Kind to Ubuntu test cases in Antrea matrix compatibility jobs. This job will automatically trigger periodic runs to ensure the ongoing compatibility of Antrea across different Kubernetes versions and configurations.
4. Enabling CAPA jobs for different OS such as CentOS or Photon."

from antrea.

XinShuYang avatar XinShuYang commented on August 17, 2024

@XinShuYang I have same question as @antoninbas , do we still want to use CAPV, we wanted to run most of the capv matrix jobs on CAPA. It might be better to split 3rd and 4th items to different issues

"3.Introducing Kind to Ubuntu test cases in Antrea matrix compatibility jobs. This job will automatically trigger periodic runs to ensure the ongoing compatibility of Antrea across different Kubernetes versions and configurations. 4. Enabling CAPA jobs for different OS such as CentOS or Photon."

@rajnkamr Yes, I created two issues to track the progress, thanks for the suggestion.

from antrea.

github-actions avatar github-actions commented on August 17, 2024

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment, or this will be closed in 90 days

from antrea.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.