GithubHelp home page GithubHelp logo

I find a bug about kingaop HOT 2 OPEN

HeavenTao avatar HeavenTao commented on August 15, 2024 6
I find a bug

from kingaop.

Comments (2)

achomoon avatar achomoon commented on August 15, 2024

I have the same question.
I change the unit test OnEntry_ShouldHaveAbilityToChange_ReferenceArgument:
for (int i = 0; i < 10; i++)
{
var entity = new TestEntity { Name = "Name", Number =i };
dynamic myTest = new MyTestClass();
myTest.ResturnObjectArgument(entity);

        }

then debug the ChangeObjectArgumentAspect.OnEntry method,
the args.Arguments is always the first time values.
this Number still is zero,
How can I fix it?

from kingaop.

tonyhallett avatar tonyhallett commented on August 15, 2024

The problem is that the BoundaryAspectGenerator generates a DynamicMetaObject with BindingRestrictions provded by the base class.

var metaObj = base.BindInvokeMember(binder, args);
// then uses metaObj.Restrictions

Debugging these restrictions you can see that there are two type restrictions
image
These restrictions are used for caching. So when the ResturnObjectArgument is invoked any time after the first the invocation is a match and the original expression tree is used.

So on second invocation the aspect gets the first TestEntity. The second TestEntity is untouched.

To avoid this a BindingRestrictions needs to be created. This could be
BindingRestrictions.GetExpressionRestriction(Expression.Constant(false));

The InterceptionAspectGenerator does similarly.

from kingaop.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.