Not able to mask struct about golang-masking-tool

[JasonLiuZhuoCheng]

For example,

	type ID struct {
	RandomField  string `mask:"email"`
	RandomNumber int    `mask:"password"`
}

type myRecord struct {
	state         protoimpl.MessageState
	sizeCache     protoimpl.SizeCache
	unknownFields protoimpl.UnknownFields
	ID            ID
	Phone         string
	Url           string `mask:"email"`
	Email         string `mask:"email"`
	Name          string `mask:"email"`
	Address       string
	CreditCard    string
}
record := myRecord{
	ID:         ID{RandomField: "sdjofij", RandomNumber: 1534250},
	Phone:      "090-0000-0000",
	Url:        "http://admin:mysecretpassword@localhost:1234/uri",
	Email:      "[email protected]",
	Name:       "John Doe",
	Address:    "1 AB Road, Paradise",
	CreditCard: "4444-4444-4444-4444",
}

maskTool := masker.NewMaskTool(filter.TagFilter(customMasker.MEmail, customMasker.MPassword))
filteredData := maskTool.MaskDetails(record)

will generate log
filter-data={"Address":"1 AB Road, Paradise","CreditCard":"4444-4444-4444-4444","Email":"dum****@dummy.com","ID":{"RandomField":"sdj****","RandomNumber":0},"Name":"Joh****e","Phone":"090-0000-0000","Url":"htt****admin:mysecretpassword@localhost:1234/uri"}
which the RandomNumber is not correct

[JasonLiuZhuoCheng]

The other use case is when I try to mask api request/response, and I am trying to mask the protobuf generated struct, something like this:

type SyncEmployeeInfoRequest struct {
	state         protoimpl.MessageState
	sizeCache     protoimpl.SizeCache
	unknownFields protoimpl.UnknownFields

	EmployeeInfos    []*SyncEmployeeInfoRequest_EmployeeInfo `protobuf:"bytes,1,rep,name=employee_infos,json=employeeInfos,proto3" json:"employee_infos,omitempty" mask:"password"`
	OriginalClientId int32                                   `protobuf:"varint,2,opt,name=original_client_id,json=originalClientId,proto3" json:"original_client_id,omitempty"`
}

and I do this to log the request:

resp, err = next(ctx, req)
maskTool := masker.NewMaskTool(filter.TagFilter(customMasker.MPassword))
			filteredData := maskTool.MaskDetails(req)
			ll := logger.Info().Str("service", service).
				Str("method", method).
				Str("version", build.Version).
				Interface("in", filteredData).

the log will be
in={"original_client_id":1} which the entire EmployeeInfos is gone. I have tried other filters like name, email, and all leads to this behavior, which makes me wonder if nested struct works or not.

[anu1097]

For example,

	type ID struct {
	RandomField  string `mask:"email"`
	RandomNumber int    `mask:"password"`
}

type myRecord struct {
	state         protoimpl.MessageState
	sizeCache     protoimpl.SizeCache
	unknownFields protoimpl.UnknownFields
	ID            ID
	Phone         string
	Url           string `mask:"email"`
	Email         string `mask:"email"`
	Name          string `mask:"email"`
	Address       string
	CreditCard    string
}
record := myRecord{
	ID:         ID{RandomField: "sdjofij", RandomNumber: 1534250},
	Phone:      "090-0000-0000",
	Url:        "http://admin:mysecretpassword@localhost:1234/uri",
	Email:      "[email protected]",
	Name:       "John Doe",
	Address:    "1 AB Road, Paradise",
	CreditCard: "4444-4444-4444-4444",
}

maskTool := masker.NewMaskTool(filter.TagFilter(customMasker.MEmail, customMasker.MPassword))
filteredData := maskTool.MaskDetails(record)

will generate log filter-data={"Address":"1 AB Road, Paradise","CreditCard":"4444-4444-4444-4444","Email":"dum****@dummy.com","ID":{"RandomField":"sdj****","RandomNumber":0},"Name":"Joh****e","Phone":"090-0000-0000","Url":"htt****admin:mysecretpassword@localhost:1234/uri"} which the RandomNumber is not correct

So for this issue, you are using customMasker.MPassword on a int type, I need to update Readme to mention that the maskers work on string coz they need to iterate over it to either mask it completely or partially. Currently support for non-string datatype is missing. Will need to add one to just replace it with some custom String. But Partial masking will not be possible.

[JasonLiuZhuoCheng]

so when will non-string datatype masking be available? When will the datatype be masked completely?

[anu1097]

So this use-case wasn't in my mind when I created the library. The masking library only masks string types in nested structures and returns in same structure. Hence Number is converted to 0 to remove sensitive information.