GithubHelp home page GithubHelp logo

Comments (7)

gepd avatar gepd commented on August 27, 2024 1

I just started to test it and I found this and the previous one, I'll wait for your fix to keep using this feature, thanks!

from choc-autocomplete.

anubra266 avatar anubra266 commented on August 27, 2024

I've found a lot of bugs, while looking at this. One being if the value is not same as innerText, there's trouble. I'll try to fix this soon.

from choc-autocomplete.

anubra266 avatar anubra266 commented on August 27, 2024

Hi @gepd. Regarding the bug I talked about, what's happening is the filter only checks the value, not the text passed to Item component. I initially made it this way for, items that rendered whole components. What do you think of accepting a label prop, that is also filtered, or if you have a better way of addressing it.

from choc-autocomplete.

anubra266 avatar anubra266 commented on August 27, 2024

By the way, I'm unable to reproduce this issue

from choc-autocomplete.

gepd avatar gepd commented on August 27, 2024

Hi @gepd. Regarding the bug I talked about, what's happening is the filter only checks the value, not the text passed to Item component. I initially made it this way for, items that rendered whole components. What do you think of accepting a label prop, that is also filtered

Yes that sound great to me

By the way, I'm unable to reproduce this issue

I tried again in a clean install (next.js) and yes, I don't see the duplication problem anymore, I'll check my first code to see where is the problem.

The second one, when the FixedItem does not show up inside a AutoCompleteGroup keep happening, I would like wrap it mostly to add a way to separate the fixed items from the Items

from choc-autocomplete.

anubra266 avatar anubra266 commented on August 27, 2024

The second one, when the FixedItem does not show up inside a AutoCompleteGroup keep happening, I would like wrap it mostly to add a way to separate the fixed items from the Items

Hi @gepd , I don't understand this.

from choc-autocomplete.

gepd avatar gepd commented on August 27, 2024

I mean, this does not work

<AutoCompleteList>
  <AutoCompleteGroup title="Title" showDivider>
    <AutoCompleteItem value="1">Apple</AutoCompleteItem>
    <AutoCompleteItem value="2">Appoint</AutoCompleteItem>
  </AutoCompleteGroup>
  <AutoCompleteGroup title="Title2" showDivider>
    <AutoCompleteFixedItem value="F1">Fixed Item 1</AutoCompleteFixedItem>
    <AutoCompleteFixedItem value="F2">Fixed Item 2</AutoCompleteFixedItem>
  </AutoCompleteGroup>
</AutoCompleteList>

from choc-autocomplete.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.