Comments (3)
Expression-bodied Metod with Expression.Empty()
Sample Non-Complaint Code
public void Foo() => Expression.Empty();
Expresion.Empty()
intends to be used in scenarios where an expression is expected, but no action is desired. This would point towards an intentional behavior rather than a code smell. At this point, this scenario would be considered a complaint code unless further questions/discussions rise in the topic.
from scanf.
Option to remove Empty Methods
In addition to option to add exception in empty methods, there should be additional code fix that enables to remove the method all together. This raises two scenarios.
- Unused Empty Methods
Non-complaint Code
public class Bar
{
public void Foo
{
var item = 3;
// Do something else
}
private void FooInternal() // Unused and Empty
{
}
}
FooInternal
in the above scenario could be removed. The method is unused and is empty. This should not provide an problem while removing.
- Used Empty Methods
This is a slightly more complex scenario as the references needs to be evaluated.
Non-complaint Code
public class Bar
{
public void Foo()
{
}
}
public class BarExtended:Bar
{
public void MethodInChild()
{
Foo();
}
}
The method could be invoked from another assembly as well. The usage path/tree needs to be tracked before removing the method.
Could be better if this option is deferred till another release
from scanf.
Documentation remaining
from scanf.
Related Issues (20)
- Create Rule List Container
- Create Rule Description Item
- Integrate Rule Definition Endpoints
- Alignment of contents is not correct in rules portal
- API calls should be cached in Vuex Store
- Publish Rules Portal
- Proposal : Async method names should have a suffix 'Async'
- Proposal : Exceptions should be "public"
- Proposal : Use .Any() instead of Count == 0
- Proposal : Pure methods should be return value
- Proposal : Constructor should not invoke any virtual methods HOT 1
- Proposal : Classes with IDisposable Fields should be disposable
- Proposal: Initialization of base static variables in constructor of derived class
- Support for .Net Standard 2.1
- Workflow for building and publishing Docfx Static website.
- Proposal : Enum Flags should always declare a NONE
- Proposal : Enums with FlagAttribute should have its values power of 2.
- Proposal: Sealed Class should not have protected members
- Proposal : Large numeric constants should use underscore for readability
- Proposal : Enums should have unique value
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scanf.