GithubHelp home page GithubHelp logo

Comments (3)

anuviswan avatar anuviswan commented on June 10, 2024

Expression-bodied Metod with Expression.Empty()

Sample Non-Complaint Code

public void Foo() => Expression.Empty();

Expresion.Empty() intends to be used in scenarios where an expression is expected, but no action is desired. This would point towards an intentional behavior rather than a code smell. At this point, this scenario would be considered a complaint code unless further questions/discussions rise in the topic.

from scanf.

anuviswan avatar anuviswan commented on June 10, 2024

Option to remove Empty Methods

In addition to option to add exception in empty methods, there should be additional code fix that enables to remove the method all together. This raises two scenarios.

  • Unused Empty Methods

Non-complaint Code

public class Bar
{
 public  void Foo
 {
      var item = 3;
      // Do something else     
 }

 private void FooInternal()  // Unused and Empty
 {
 }
}

FooInternal in the above scenario could be removed. The method is unused and is empty. This should not provide an problem while removing.

  • Used Empty Methods
    This is a slightly more complex scenario as the references needs to be evaluated.

Non-complaint Code

public class Bar
{
 public void Foo()
 {
 }
}

public class BarExtended:Bar
{
 public void MethodInChild()
 {
   Foo();
 } 
}

The method could be invoked from another assembly as well. The usage path/tree needs to be tracked before removing the method.

Could be better if this option is deferred till another release

from scanf.

anuviswan avatar anuviswan commented on June 10, 2024

Documentation remaining

from scanf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.