GithubHelp home page GithubHelp logo

Comments (21)

remod avatar remod commented on August 20, 2024 1

Yes that sounds great!

One input from my side: ROS2 brings along some code formatting tools. To ensure that potential bugfixes are compatible with both versions of rqt_multiplot_plugin, ROS1 and ROS2, I suggest that we do not reformat code on the ROS2 branch - is this fine for you?

from rqt_multiplot_plugin.

abrzozowski avatar abrzozowski commented on August 20, 2024 1

Ok, I thought about it. I will be changing as minimally as possible. This approach should help with future merging ros1-releases into ros2 as well

from rqt_multiplot_plugin.

remod avatar remod commented on August 20, 2024 1

Yes exactly. In case you are not aware, the variant package does some ROS message definition parsing. Porting it to ROS2 might involve a bit more work than usually when porting a node.

from rqt_multiplot_plugin.

yossioo avatar yossioo commented on August 20, 2024

@kralf
Maybe some guides where to start for those who dare to try? :)

from rqt_multiplot_plugin.

AmaurX avatar AmaurX commented on August 20, 2024

I would also be very interested for a ROS2 Foxy version. I'll like to try but a guide to which files are specific to ROS and which are not would be nice.
Also, one big issue will definitely be the issue of QoS compatibility between publishers and subscribers

from rqt_multiplot_plugin.

GuihVicentini avatar GuihVicentini commented on August 20, 2024

Any update on this? I am also interested on running multiplot on ROS2. Did anyone found another solution or a guideline to adapt this solution?

from rqt_multiplot_plugin.

remod avatar remod commented on August 20, 2024

Hello everyone,

we do not have plans at the moment to port this package to ROS2. If anyone wants to contribute, I am happy to create a ros2 branch!

from rqt_multiplot_plugin.

GuihVicentini avatar GuihVicentini commented on August 20, 2024

Hi @remod I kind of have interest on this, but I am clueless on what are exactly the ROS1 dependencies on this project. Could you give me a starting point?

from rqt_multiplot_plugin.

remod avatar remod commented on August 20, 2024

Hi @GuihVicentini

I am unsure whether I understood the question correctly - does the migration guide to ROS2 help?

from rqt_multiplot_plugin.

abrzozowski avatar abrzozowski commented on August 20, 2024

Hi @remod,

First overall, @kralf, @remod and others, kudos for the fantastic project!

It would be super to have this plugin in ROS2. Were there some steps taken in this direction?
If not, I can take care of it. I will be doing it in my free time, so it probably will take a while to do this porting, but I hope not longer than to end of this year :P

from rqt_multiplot_plugin.

remod avatar remod commented on August 20, 2024

Hi @abrzozowski

That would be great, thank you! We're still using ROS1 and therefore cannot assist with the implementation, but we can help with the review! How would you like to proceed? Create a ros2 branch?

from rqt_multiplot_plugin.

abrzozowski avatar abrzozowski commented on August 20, 2024

Hi @remod,

Great! I will create a fork of this repo, and I will be porting on this fork. When everything works, I will create a PR to this main repo (https://github.com/ANYbotics/rqt_multiplot_plugin). Then we'll do the review. Is it a good plan?

I think that creating a ros2 branch in the main repo is an excellent idea because it can show others that there is someone who works on porting.

from rqt_multiplot_plugin.

abrzozowski avatar abrzozowski commented on August 20, 2024

I've taken a look at what is a work scope. There is one more package to port except this, a https://github.com/ANYbotics/variant. The rqt_multiplot_plugin is dependent on the variant

from rqt_multiplot_plugin.

nlamprian avatar nlamprian commented on August 20, 2024

Is there any ongoing activity on this topic?

from rqt_multiplot_plugin.

remod avatar remod commented on August 20, 2024

Hi @nlamprian !

I personally am not aware of any activity.

from rqt_multiplot_plugin.

nlamprian avatar nlamprian commented on August 20, 2024

OK, I'll see if I can get involved. This tool deserves to stay alive!

from rqt_multiplot_plugin.

remod avatar remod commented on August 20, 2024

Nice to hear, thank you! :)

from rqt_multiplot_plugin.

nlamprian avatar nlamprian commented on August 20, 2024

I'm back with rqt_multiplot_bridge. I chose the less painful option of using a ROS bridge. This will have to do for now.

I also tried to make it work with docker compose, but the window would not open. If you have any idea how to configure it, feel free to open a PR.

from rqt_multiplot_plugin.

abrzozowski avatar abrzozowski commented on August 20, 2024

Hi, guys. Unfortunately, from my side, the porting didn't really move forward. The variant also still needs to be ported. But I still hold onto the hope that I'll get it done this year.

from rqt_multiplot_plugin.

amburkoff avatar amburkoff commented on August 20, 2024

I really liked using rqt_multiplot on ros1. Any news on porting to ros2?

from rqt_multiplot_plugin.

abrzozowski avatar abrzozowski commented on August 20, 2024

Unfortunately, I haven't found the time so far to do it. So, officially, I'm saying that I'm not currently dealing with it :(

from rqt_multiplot_plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.