anylsite / smart-contracts Goto Github PK

currently anyone can alter the device table by calling updateDeviceRegistration

The current implementation handles error and result scenarios at 'Invoke' level. Also it expects that result should always be a string which makes child method to convert any data to string. If we can handle this at function level, it'll remove the dependency of creating string.
Also adding some log statements helps understanding what's going on in prod environment.

no need to store three bools in the contract. uint8 should be enough.

owner variable shouldn't be hardcoded

owner check should also use modifier instead of test in the function

There's no way to read existing device info once stored using 'UpdateDeviceRegistration' method.
Adding a 'Query' method helps to read the latest state on any key on the chain.