GithubHelp home page GithubHelp logo

Comments (8)

alamb avatar alamb commented on June 2, 2024 2

As I understand it, the usecase for GuaranteeRewriter when @wjones127 (maybe?) added it was for providing external information (outside of information that came from SQL). I don't think we should just remove the ability to do so

I would personally recommend add code that translates Statistics into Guarantees to pass to GuaranteeRewriter

We could discuss reworking how GuaranteeRewriter works as a follow on PR

from arrow-datafusion.

jayzhan211 avatar jayzhan211 commented on June 2, 2024 1

@jayzhan211 Do I understand correctly that the best option is to incorporate the guarantee logic into the simplifier based on statistics and remove the old version of the guarantee?

I think so.

from arrow-datafusion.

yyy1000 avatar yyy1000 commented on June 2, 2024

Update: #10463 is not what this issue expects, I will see what to do next.
I can help it. :) An experimental PR is #10463

from arrow-datafusion.

yyy1000 avatar yyy1000 commented on June 2, 2024

On a second glance, I feel it's difficult. 😥
When simplifying a logicalplan, it seems impossible to get the underlying data which could making guarantees.

from arrow-datafusion.

alamb avatar alamb commented on June 2, 2024

I think this may be another example of what @samuelcolvin was suggesting on #10400

I think we could use ExecutionPlan::statistics to get the guarantee information

from arrow-datafusion.

dmitrybugakov avatar dmitrybugakov commented on June 2, 2024

@jayzhan211
Do I understand correctly that the best option is to incorporate the guarantee logic into the simplifier based on statistics and remove the old version of the guarantee?

from arrow-datafusion.

alamb avatar alamb commented on June 2, 2024

old version of the guarantee?

What does "old version of the guarantee?" refer to?

from arrow-datafusion.

dmitrybugakov avatar dmitrybugakov commented on June 2, 2024

What does "old version of the guarantee?" refer to?

impl<'a> TreeNodeRewriter for GuaranteeRewriter<'a> {

from arrow-datafusion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.