Android: executeScript failing for large return values (length greater than 10240) about cordova-plugin-inappbrowser

[ianhowe76]

I implemented a fix that seems to work ok

Instead of calling injectDeferredObject in the injectScriptCode branch (here: https://github.com/apache/cordova-plugin-inappbrowser/blob/master/src/android/InAppBrowser.java#L254)

I instead call my new function runJavascriptWithResult(args.getString(0), callbackContext)

The implementation of this function is

private void runJavascriptWithResult(String scriptToInject, CallbackContext callbackContext) {
        final String finalScriptToInject = scriptToInject;
        final CallbackContext finalCallbackContext = callbackContext;
        final String callbackId = callbackContext.getCallbackId();
        this.cordova.getActivity().runOnUiThread(new Runnable() {
            @SuppressLint("NewApi")
            @Override
            public void run() {
                inAppWebView.evaluateJavascript(finalScriptToInject, new ValueCallback<String>() {
                    @Override
                    public void onReceiveValue(String s) {
                    	PluginResult pluginResult;
                    	try {
                          pluginResult = new PluginResult(PluginResult.Status.OK, new JSONArray("[" + s + "]"));
                        } catch(JSONException e) {
                            pluginResult = new PluginResult(PluginResult.Status.JSON_EXCEPTION, e.getMessage());
                        }
                        finalCallbackContext.sendPluginResult(pluginResult);
                    }
                });
            }
        });
    }

Would this be a suitable fix? If so I can create a PR

[janpio]

Did I understand correctly that this probably does not apply only for this plugin but all cordova-android communication?

[ianhowe76]

Anyone using prompt interface for the javascript-Java communication is affected by this Chrome update
As this plugin uses prompt for communication it affects this plugin
Is prompt interface used elsewhere within Cordova?

[janpio]

I don't know - I was hoping you knew ;)

[prbehera8]

Hi ianhowe76, Is the fix also works for Chrome latest version 71.

[ianhowe76]

I have only tested personally on 70.0.3538.80, however, the app that is using this patch hasn't had any customer complaints since
I am planning on creating a PR for this soon

[ianhowe76]

PR to fix this is #395