Comments (8)
The PR changes look good to me:
as @jonathanli2 points out, the synchronous return value is never used in CDVWKInAppbrowser since the result is returned asynchronously via the postMessage API.
The loop was just a hangover from the UIWebView implementation that I forgot to take out.
from cordova-plugin-inappbrowser.
Add the comment from
https://stackoverflow.com/questions/26778955/wkwebview-evaluate-javascript-return-value
"This solution IS NOT WORKING anymore. The callback now called from the main Thread and if you lock the main thread in the while loop (like in this solution), the callback handler will be never called. evaluateJavaScript waits for main thread released, but it never happens because it locked in the loop. – Mike Keskinov Sep 4 at 0:21"
from cordova-plugin-inappbrowser.
As the return value from CDVWKInAppbrowser's evaluateJavascript method is actually never used, it may well just changes the function signature to
- (void)evaluateJavaScript:(NSString *)script
and so we can remove the while loop which blocks the method from returning.
Thanks
Jonathan
from cordova-plugin-inappbrowser.
A change has been made at the pull request
#341
from cordova-plugin-inappbrowser.
Could you take a look please @dpa99c?
from cordova-plugin-inappbrowser.
Any update for this pull request?
from cordova-plugin-inappbrowser.
The pull request has been merged, and the issue is closed.
Thanks
Jonathan
from cordova-plugin-inappbrowser.
(FYI: If you use closes #340
in the text of a PR, it will automatically close the issue when the PR is merged. Can use that for your next PR.)
from cordova-plugin-inappbrowser.
Related Issues (20)
- Calling window.print() does not work
- Keychain not work with inappbrowser HOT 1
- Disable close button (Done) for iOS
- InAppBrowser does not open Youtube Links Properly HOT 12
- The preference name "MediaPlaybackRequiresUserAction" has been deprecated. It is recommended to replace this preference with "MediaTypesRequiringUserActionForPlayback."
- When can we expect latest 6.0.0 version release on npm? HOT 1
- The www/inappbrowser.css file should be removed because it was only for the Windows platform HOT 1
- Cannot build iOS Ionic Capacitor project HOT 5
- 6.0.0 Update throws error while archiving iOS project: "'Cordova/CDVWebViewProcessPoolFactory.h' file not found" HOT 1
- "browser.on('loaderror')" does not work properly on iOS.
- executeScript not working in colab HOT 4
- How to build this plugin for node_modules? HOT 2
- Add option to respect/ignore safe area on iOS
- ref.executeScript can't write clipboard HOT 5
- window.open doesnt work inside the opened webview HOT 2
- Warning when submitting to play store - JavaScript Interface Injection HOT 3
- @awesome-cordova-plugins/in-app-browser, this plugin is not sending the device id to azure while login + iOS HOT 3
- Angular 15 webpage not loading correctly in inappbrowser (Android < 11) HOT 1
- Hide Location & toolbar on scroll
- No visible @interface for 'UIApplication' when building an app for iOS HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cordova-plugin-inappbrowser.