Comments (16)
Awesome.
So what you want to do is create a Pull Request (PR) from a branch in a fork of this repository where you changed those files.
Small glossary:
- Pull Request = Like an issue, but has code attached to it that can simply be merged into the original repository
- Branch = A "branch" in a repository with some changes. There mostly is a
master
branch that has the main code, and many other branches with slight modifications. That way you can have a branch for each bug, feature etc. and it is easy to see only the changes for that - Fork = Copy of a repository under your username. At first a fork is just a copy, but then you can make changes in there (you can't do that here because you don't have access) and send a PR with those changes later.
Now some links with instructions what you have to do:
- Fork the repo: https://help.github.com/articles/fork-a-repo/ Really relevant is just this bit: https://help.github.com/articles/fork-a-repo/#fork-an-example-repository
- Make changes in your repository: Now you can check out your fork with Git to your computer, change the files and commit and push the changes: https://help.github.com/articles/cloning-a-repository/ + https://help.github.com/articles/adding-a-file-to-a-repository-using-the-command-line/
Or you can do it online on Github.com in the UI: https://help.github.com/articles/editing-files-in-your-repository/ - When you have edited both files in your fork, you can create a pull request on this repository to get your changes back here: https://help.github.com/articles/creating-a-pull-request/
- Then we have a Pull Request here with your changes that we can look at.
This seems like a lot now, but it is just a few simple steps once you understood it. Let me know if you hit any stumbling blocks, I'll be happy to help you along the way.
from cordova-plugin-splashscreen.
from cordova-plugin-splashscreen.
Common misunderstanding: You are creating the pull requests from the branch in your fork to master
in your fork. They show up here: https://github.com/sdgpalm2/cordova-plugin-splashscreen/pulls You have to create the Pull Request to this repository, for example by creating the PR here: https://github.com/apache/cordova-plugin-splashscreen/compare
As I saw your two PRs, I noticed you edited the files in two different branches - sdgpalm2-patch-1 and sdgpalm2-patch-2 - which means you also need two PRs to get all the changes in. This should not be the case, you should try to edit both files in the same branch. You can do that by either going to one of the branches in your repository and also edit the other file, or create a Pull Request from one branch to the other, merge it and then merge that branch into the Cordova repository.
Let me know if this works.
from cordova-plugin-splashscreen.
from cordova-plugin-splashscreen.
Not really, congratulations on your first PR! π₯ π―
(The tests are failing, but that is because they are failing for all commits because of a infrastructure problem, the actual code tests seem to be fine)
You can add closes #158
in the description field, then it will automatically close this issue when it is merged.
Now someone from the Apache Cordova team will have to look at, review and then merge it.
from cordova-plugin-splashscreen.
Hi, iPhone XsMax and iPhone Xr have the same height in points (896) but not in pixels (2688, 1792 pixels), the launch images are not the same size in xcassets, there are distinct images for XsMax and Xr launch screen, you have to go with native screen bounds to detect the right iPhone model...
CDVSplashScreen.zip
from cordova-plugin-splashscreen.
@Stefano1964, can you follow the same steps I posted above to create a PR please?
from cordova-plugin-splashscreen.
This is my own version, i do not fork @sdgpalm2...
Edited and tested in Xcode...
from cordova-plugin-splashscreen.
Exactly, a new PR for the changes you made so they can possibly be integrated back into this plugin.
from cordova-plugin-splashscreen.
Pull #159 has been updated with code provided from @Stefano1964
from cordova-plugin-splashscreen.
@sdgpalm2 thanks, i'm really busy in this days.
Also note that if you are editing an existing project in Xcode 10 the launch image for XsMax and Xr dont show up, you have to delete and recreate launch image xcassets:
https://stackoverflow.com/questions/52402062/iphone-xs-max-xr-not-able-to-use-native-resolution-when-using-launch-images-in
from cordova-plugin-splashscreen.
@Stefano1964, I've been using Asset Catalog Creator and did remove and replaced the xcassets, I even cleared the apps from the simulators and all the graphics did show up for me, but anyways, after reading your code, thought your process was correct, part of testing of your code yesterday was to edit the three images and place the works "X XS", "XR", "XSMax" into their respected selfs and did verified that they did show up correctly at launch based on the selected Xcode simulator, Thanks again!
from cordova-plugin-splashscreen.
@sdgpalm2 it's working fine if the app is launched in portrait mode but not in landscape because i made an error, i was testing only height, we have to test both height and width as the original code for points does. Attached the last version.
CDVSplashScreen.zip
from cordova-plugin-splashscreen.
@Stefano1964, code has beed code applied.
from cordova-plugin-splashscreen.
Hi, iPhone XsMax and iPhone Xr have the same height in points (896) but not in pixels (2688, 1792 pixels), the launch images are not the same size in xcassets, there are distinct images for XsMax and Xr launch screen, you have to go with native screen bounds to detect the right iPhone model...
CDVSplashScreen.zip
Not Working in cordova 9.0 and ios5.0 version .
from cordova-plugin-splashscreen.
The plugin has been integrated into cordova-ios 6, so no more iOS work will be done here.
Also, it now uses the launch storyboards, so this shouldn't be an issue anymore.
If there are still other bugs on the cordova-ios 6 implementation, report them on https://github.com/apache/cordova-ios/issues
from cordova-plugin-splashscreen.
Related Issues (20)
- Why is there no IOS platform HOT 2
- show default cordova splash screen not real splash screen in iphone x HOT 1
- Fade options in browser
- unsafe areas behind notches in the screen. HOT 2
- Installation on ios and android HOT 2
- Splash screen is not hiding with this.splashscreen.hide() after migrated to cordova-ios >=6 HOT 8
- iOS splash screen loader not showing HOT 6
- Splashscreen start with statusbar in Cordova 10 HOT 1
- Overlap with the new Android 12 SplashScreen API HOT 14
- Splashscreen freeze in testflight but working in emulator HOT 2
- iOS Launch screen images do not display in emulator and required to be copied to a Xcode project folder HOT 1
- Why black screen before splash screen and white screen after splash screen in android? HOT 6
- Tried calling SplashScreen.hide, but the SplashScreen plugin is not installed on Android 12 HOT 6
- Showing multiple splash in android 12 HOT 1
- cordova plugin splash sceen not working in android11 for cordova HOT 2
- The icon is not shown on first launch. Background only. HOT 1
- Support Cordova-Android 12.0.0 (current version) HOT 3
- Disable Splash Screen on reboot HOT 2
- some things about `cordova-plugin-splashscreen` HOT 2
- Not able to upgrade for ionic 7 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cordova-plugin-splashscreen.