GithubHelp home page GithubHelp logo

Comments (5)

ppkarwasz avatar ppkarwasz commented on August 15, 2024 1

Hello @Karthi1711,

Can You submit a PR with the changes?

from logging-log4j2.

garydgregory avatar garydgregory commented on August 15, 2024

I think we want to be careful here @ppkarwasz: Do we really want to lock down an API as public for such low level classes and be bound to binary compatibility? Or are we going to say this class is not part of BC?

from logging-log4j2.

ppkarwasz avatar ppkarwasz commented on August 15, 2024

@garydgregory,

I would just prefer to see this request in the form of a PR, that we can discuss on the code.

from logging-log4j2.

Karthi1711 avatar Karthi1711 commented on August 15, 2024

PR created: #1683.

from logging-log4j2.

vy avatar vy commented on August 15, 2024

@garydgregory, I see the points you raise. We already expect users to implement RolloverStrategys, which is a public interface. In all of our own implementations of RolloverStrategy, we reach out to FileExtension methods the user is requesting to expose. Hence, I find it fair that custom RolloverStrategys should have access to those methods.

from logging-log4j2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.