GithubHelp home page GithubHelp logo

Change callback parameter order about nano HOT 6 CLOSED

apache avatar apache commented on August 27, 2024
Change callback parameter order

from nano.

Comments (6)

thiagoarrais avatar thiagoarrais commented on August 27, 2024

If people choose to go with this, I am willing to do the changes, of course.

from nano.

dscape avatar dscape commented on August 27, 2024

Hi Thiago,

This seems reasonable to me. And overall looks like a better api decision. The reason why it is the way it is is because of request. So I wonder what @mikeal thinks about this, maybe there's a reason he set the body as the last parameter of the callback?

If not I'll change this and set it as a 1.0 feature

from nano.

dscape avatar dscape commented on August 27, 2024

This would also require:

  • Updating the documentation
  • Updating the blog post
  • Updating all the tests

from nano.

thiagoarrais avatar thiagoarrais commented on August 27, 2024

Sure. When I volunteered points 1 and 3 were certainly included (together with the library code, obviously). I am not sure I can mess with your blog, though...

from nano.

dscape avatar dscape commented on August 27, 2024

@thiagoarrais messing with blog is fine :) Check dscape/dscape.github.com

If no one (@jchris, @pgte, @daleharvey) gives a reason why this would be a problem in the next 24 hours please do submit a pull request!

Thank you!

from nano.

mikeal avatar mikeal commented on August 27, 2024

is body a string or the parsed object?

why don't you parse the object and just set an _headers property on it?

from nano.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.