Comments (5)
The objective here was simplicity. A simple git clone is enough to get you started with nano
.
If you check nano git ignore you will see that I have node_modules
there. However I added it after versioning request
and underscore
, cause I felt like it was ok to keep them there. In other words this was deliberate :)
The current version of request is still unpublished in npm
, so that can't match. That includes fixes for proxy authentication, StrictSSL, and several global vars leaks to cover just some of the cases.
I can remove the versioning of request if you like, just considered simpler to have it for now. If you feel strongly about it send in a pull request :)
from nano.
No, I think you make a good point.
from nano.
I actually check all my dependencies in to git in node_modules.
It makes collaboration easier, you can see diffs for the changes in dependencies when you upgrade the version.
-Mikeal
On Sep 20, 2011, at September 20, 20118:43 AM, Jason Smith wrote:
Hi, Nuno. Is it correct to include
node_modules
in the Git code? I thought that is out of scope for source builds (obviously it is put there bynpm install
but that is a "binary build" IMO).In my own code I always put
node_modules
in the.gitignore
however I have no idea if that is correct or not.Any thoughts?
Reply to this email directly or view it on GitHub:
#20
from nano.
@mikeal And then when you npm publish
they are simply not bundled, I presume?
That's pretty cool.
from nano.
Well, you can do a bundle push that will bundle them, but they won't be bundled if you don't do that kind of push.
For deployment, IMO, you should always do a bundle push of all your pure-js deps. Deps that have to be compiled are another story tho.
The only place this all gets complicated is when you're using npm link and developing the dependency as well. git won't follow sym links :(
-Mikeal
On Sep 20, 2011, at September 20, 201110:28 AM, Jason Smith wrote:
@mikeal And then when you
npm publish
they are simply not bundled, I presume?That's pretty cool.
Reply to this email directly or view it on GitHub:
#20 (comment)
from nano.
Related Issues (20)
- Does nano support purge? HOT 2
- db.attachment.get file- 'could not be opened because it is empty'
- Can not get correct userctx HOT 2
- Couch DB 2 compatibilty HOT 3
- bulk() with _deleted:true causes error HOT 3
- db.multipart.get does not work with Cloudant Local 1.0.0.5 HOT 1
- Enable permanent replication by writing to "_replicator" database instead of "_replicate" database. HOT 3
- Support temp view
- Doubt on db access of live app HOT 2
- What is the keys in view function based on? Is it the key you emit in the views/map function? HOT 1
- How do you update _rev to update a document?
- uploaded files displaying base64 data in the browser (attachments not viewable)
- Problem with OR -clauses? HOT 1
- Error: badarg every few hours
- Error: {error,emfile} HOT 1
- Example Lazy Creation of View
- Query string encoded when using array of keys
- Database permissions
- db.fetch array of id error
- Attempting to return simple list of documents, small issue
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nano.