GithubHelp home page GithubHelp logo

Comments (4)

dscape avatar dscape commented on August 27, 2024

This should be possible with request (http://github.com/mikeal/request).

So in my opinion this should be done when you instantiate the nano Object.

I think this is already possible:

I'm going to close the issue, unless you state this isn't sufficient. If it's not and you would like to contribute this functionality I would accept it. Just:

  • Add documentation to readme.
  • Add a cookie.js test in shared.

When making the tests please look at branch issue63 as this is the future for nano in terms of testing. Anything but the doc folder as I am currently finishing it up.

ps. issue63 is a significant refactor wich will likely:

  1. make peoples life easier in contributing to the project (or at least I hope so)
  2. better code quality
  3. using errs for errors as opposed to having a separate class
  4. removing logger.js
  5. Fixing issue #63
  6. Update to latest version of dependencies and devDependencies, including updating all the tests

from nano.

rapidrapids avatar rapidrapids commented on August 27, 2024

The problem with this, is that it means that the developer must have the cookie at the point of instantiation (as far as I'm aware). Which prevents you from simply having nano = require('nano')('http://localhost:5984'); at the start of your file.

I personally feel that its necessary for the developer to have more granular control over when to send a cookie.

Alternatively, if there is a way of updating the config of an instance of nano after its instantiation then that would be another option I guess.

from nano.

dscape avatar dscape commented on August 27, 2024
Alternatively, if there is a way of updating the config of an instance of nano
after its instantiation then that would be another option I guess.

Yes, you can create multiple instances of nano. So this is fine.

Because it's an exception and would force you to change all methods, I think this is preferable.

Please feel free to send a pull request, can't wait to add you to the contributors list.

Also feel free to add your projects that use nano to the wiki.

from nano.

dscape avatar dscape commented on August 27, 2024

Nano 3 is out.

This should fix this.

Please reopen if you can't fix the problem you have using it :)

Thank you!

from nano.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.