GithubHelp home page GithubHelp logo

Comments (4)

Mahmoudz avatar Mahmoudz commented on June 21, 2024 1

@denizdogan all my requests implement the authorize() and the rules() functions.
I updated the doc to make the authorize() REQUIRED instead of OPTIONAL.
What do you think I should else fix or include in the Documentation?

from apiato.

denizdogan avatar denizdogan commented on June 21, 2024

Further investigation shows that if I subclass App\Port\Request\Abstracts\Request, I must also implement authorize. Then it works.

from apiato.

denizdogan avatar denizdogan commented on June 21, 2024

@Mahmoudz: Thanks, I feel like we can close this issue now.

In the future development of Hello API, maybe we could refactor some things about the way Request objects work? Too often I have to override the all method, which feels like a hack. It's like URL parameters are second-class citizens compared to "real" parameters, but many routes use only URL parameters! :)

from apiato.

Mahmoudz avatar Mahmoudz commented on June 21, 2024

@denizdogan 100% that needs refactoring, so far the only working solution for that is to hack the all() function. Maybe we can add some nice function in Hello API for that or contribute to the Laravel core with a nicer solution..

from apiato.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.