Comments (3)
Hello and thank you for the bug report. Since you already identified the cause, are you interested in submitting a PR?
from crawlee.
Sure, will do later. I'd go with returning undefined
when the underlying solution returns undefined
, as it would be less disruptive. Most people tend to do short checks like if (!robots.isAllowed(...))
, therefore it wouldn't change existing behavior.
from crawlee.
Sure, will do later. I'd go with returning
undefined
when the underlying solution returnsundefined
, as it would be less disruptive. Most people tend to do short checks likeif (!robots.isAllowed(...))
, therefore it wouldn't change existing behavior.
That sounds less than optimal to me - 1. it does not make the code sample in your bug report work and 2. it makes the return type harder to understand - does boolean | undefined
mean true/false/don't know? Or something else?
If undefined
means "robots.txt does not say anything about the URL", I'd say isAllowed
should return true - just like you wrote in the code sample.
from crawlee.
Related Issues (20)
- Refactor `retireOnBlockedStatusCodes` to `isBlockedStatusCode` and move the retiring out of the `Session` class
- `AdaptivePlaywrightCrawler`: programmatically deciding when to render JS HOT 3
- Cheerio crawler going out of memory unexpectedly with lot of concatenated strings
- Support reading sitemap from a variable
- Trouble unzipping `sitemap.xml` (`zlib: incorrect header check`) HOT 5
- handledRequestCount from requestQueue.getInfo() after restart is 0 HOT 1
- Improve docs about request locking HOT 3
- Load more function for google maps
- Rename `Job` from statistics module to `RequestProcessingRecord`
- Replace spaces with tabs for indentation
- Consider porting over `ContextPipeline` from the Python counterpart
- Remove experimental containers in browser pool
- Remove version private field from browser pool
- Proxy authentication error HOT 1
- URLs rejected from file HOT 4
- Third-party proxy IP does not take effect
- Unify `RequestList` and `RequestProvider` interfaces and extract their "tandem" behavior from `BasicCrawler`
- Investigate a more explicit way of detecting retries in `ProxyConfiguration`
- Proxy changes for same session
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from crawlee.