Comments (3)
Fully agree with the points raised about malicious code. Even more so every PR author could de-facto deploy arbitrary proxies in the devrel org.
To reduce the chance of unwanted turnaround times during code reviews we could also split the current run-pipeline.sh
into:
- pre-deploy: Consisting of static code analysis, unit testing and potentially packaging
- deploy: Consisting of the proxy deployment as well as all the testing against the deployed proxies.
And have the pre-deploy
phase run automatically (without any Apigee credentials or environment) and manually trigger the second deploy step.
from devrel.
It might also be worthwhile to discuss if the individual proxies need to remain deployed after the deployment is verified. This could prevent us from clients calling the devrel org proxies outside of the automated deployment pipeline and validation. Additionally we would not necessarily restrict multiple demos/labs from overlapping in their base path.
from devrel.
Well, there is not much else we can do I guess then splitting the execution as you explained there @danistrebel. Luckily run-pipeline
naturally seems split in that way - the parts before and after the individual solution pipeline
execution steps.
So any PR that fixes this issue could look at the nightly/PR flags and decide whether to execute individual pipeline
s or not.
Your idea to potentially cleanup the org is a good one as well but I feel it can be implemented in a separate issue as it is not a blocker atm.
Makes sense?
from devrel.
Related Issues (20)
- Nightly build failure HOT 1
- cloud-run deployment fails with 403 HOT 1
- Nightly build failure HOT 2
- Sackmesser - Deploy multiple proxies at once HOT 4
- Sackmesser - Two apikeys getting created while migrating apps. HOT 2
- Nightly build failure HOT 1
- Nightly build failure HOT 2
- Nightly build failure HOT 89
- skip Apigee ci action for release bot PR HOT 1
- [hybrid-quickstart] Workload identity support for org-scoped UDCA
- :grey_question: Unsupported OpenAPI version: 3.0.3 HOT 2
- Nightly build failure HOT 21
- Sackmesser - Developer Email Address - Casing HOT 1
- Nightly build failure HOT 1
- Nightly build failure HOT 41
- Minor issue with default key/secret for Hello World App HOT 3
- For oas-configurable-proxy - needs updating
- Nightly build failure HOT 49
- Unable to extract and read the scope values from OA2-GetOriginalStateAttributes.xml on the identity-facade reference HOT 2
- Nightly build failure HOT 33
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from devrel.