Erase old backers record about selfstarter

[codefrosty]

Oh man, I hope this gets fixed really soon. Thank you for creating the issue. I wonder if this bug is live and how many actual backers are there on Lockitron.com

[ccamrobertson]

The number of backers should be based on a count of valid Amazon tokens that have been returned to Selfstarter. When you are in the sandbox mode, you can create a bunch of fake orders quickly that provide fake multi-auth tokens. Is this what occurred? Or did you cancel/leave Amazon midway through?

People who start an order but don't finish should not be counted - even in sandbox mode.

If a person cancels their order, you should have a valid IPN endpoint which then deletes the order on Selfstarter.

For third party verification, these tokens can be provided to someone else who can call them against the Amazon service to see if they are real.

[Jarred-Sumner]

I just pushed a fix.

With Lockitron.com, we had to modify certain parts of Selfstarter because the code for Selfstarter was too tightly coupled with the rest of our codebase -- we kind of rushed this out without testing it enough first.

The problem was that it did Order.count which literally counts all the rows in the orders table -- now, it does Order.where("token != ? OR token != ?", "", nil).count --- token is where we store Amazon's multi-use token. When the checkout process is successful, Amazon passes us back this multi-use token, and, when the product is ready to ship, we use it to actually charge the credit card. Now, this will count the orders based on the orders with multi-use tokens.

[yulau]

Thank you very much for your help and explanation!
I'll try to work it out.