GithubHelp home page GithubHelp logo

Comments (6)

weigler avatar weigler commented on May 28, 2024

This is a good idea... receive the volume and not each chapter.

from kmanga.

JohnEdwa avatar JohnEdwa commented on May 28, 2024

Doing it by volume would only work if the source gave that information which most don't.

But I totally agree, there should be a way to bundle the chapters together before being sent, especially when there are more and more mangas with very short chapters - the ridiculously named "A Story About Treating a Female Knight Who Has Never Been Treated as a Woman as a Woman" for example has usually 4-8 pages per 'chapter'.

from kmanga.

aplanas avatar aplanas commented on May 28, 2024

There is a limit, tho, as amazon have a size limit for documents send by email. Also @JohnEdwa is right, most of the sites do not provide volume information, or provide it in random ways (partially hinted in the name of the chapter)

I can sacrifice cache reuse in favor of conglomerating several chapters, but to make it practical (no surpassing the size limit) I need first to decrease the weight of each image.

Overall this makes sense to me, but this will require some time.

from kmanga.

JohnEdwa avatar JohnEdwa commented on May 28, 2024

It would make sense to swap the hardcoded 30 sends/day limit to mo of a 'credit' system where what and how you send makes a difference depending on how intensive it is.
For an example, 30 chapters of Berserk is around 700 pages while the same for Female Knight is around 180 - and if ask to combine the Female Knight all into one (as it should still fit the 50MB amazon limit), it is sending just one file, but having to process the 30 chapters and 180 pages, so should it count as 1, 30, or something in-between?
There are also some extreme examples where a 'chapter' is actually just one page. If I can ask for 700 pages of berserk, shouldn't I be able to combine hundreds of 'chapters' to one file with this one?

from kmanga.

aplanas avatar aplanas commented on May 28, 2024

@JohnEdwa that is a very interesting proposal. The limit is there because the server have some limitations. So is not fair consider a 30 pages chapter the same as a 10 pages one.

But I can see a big issue. One is that this is very hard to communicate to the user, as kmanga have no clue about the size of the chapter (and knowing it before hand will impose a big load to the original source, as I need to make at least one more request per chapter, per manga, per site)

If I use some kind of 'you have 5M of images for today' is a bit fuzzy measure, as this limit can be from the input (before the image is resized), for computing (during the resize) or for output (once the MOBI is created)

But I will think more about this idea.

from kmanga.

JohnEdwa avatar JohnEdwa commented on May 28, 2024

Hmmmh, true, the lack of information is an issue.

I think basing it on the before sizes would be the fastest as that way you can detect when something is going to be too much the moment you've downloaded enough chapters without having to process them. The point is, after all, to get a reasonable amount of chapters into one file and not a 'who gets closest to 49.999MB' competition.

As for how to handle the credits, one way I thought of handling the ambiguity could be allowing storing and going negative up to some reasonable limits, as most people have multiple days without having anything sent after all.
So let's say you get 100 credits/day but you can hold 500 and go -500 negative.
When your credits are between 0-200 you can ask to send stuff, but if what you ask happens to be bigger than what you have left for that day, it uses your banked credits. If it's really big, you go to the negative and can't ask anything until you've refresh enough.

from kmanga.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.