localForage and persistCache type collision about apollo-cache-persist

[Hasan-git]

@mohsen1
it works for me.

        const __STORAGE__= localforage as any;

        const persistor = new CachePersistor({
            cache,
            storage: __STORAGE__,
            maxSize: false, 
            debug: false
        });

[lukepighetti]

I was just about to create an issue for this.

Type 'LocalForage' is not assignable to type 'PersistentStorage<PersistedData<NormalizedCacheObject>>'.
  Types of property 'setItem' are incompatible.

import ApolloClient from "apollo-boost";
import { InMemoryCache } from "apollo-cache-inmemory";
import { persistCache } from "apollo-cache-persist";
import * as localForage from "localforage";

const cache = new InMemoryCache();

persistCache({
  cache,
  storage: localForage
});

export const client = new ApolloClient({
  uri: "http://localhost:4000",
  cache
});

If this is not how localForage is intended to be used, can someone provide docs or a quick example?

[wilmervanheerde]

Since the readme states that localForage is supported, would it be an idea to remove that from the documentation?

[nolram88]

I've got the same issue

[Hasan-git]

same here, any updates ?

[wtrocki]

Btw. Localforage will come with lots of baggage related to old browsers and his implementation will not be optimal in terms of performance.
Using something like https://www.npmjs.com/package/localstorage-idb-keyval will be much better and match interface quite nicely.