GraphQL HoC doesn't re-render with data.error set when GraphQL error occurs about apollo-link-state

[jbaxleyiii]

➤ Mattias Ewers commented:

This is an issue for me as well.

[jbaxleyiii]

➤ Jim Kynde Meyer commented:

This issue appears to be more critical than I initially thought.

I'm now seeing stale data.props that are out of sync with what is in the InMemoryCache after mutations. See the attached screenshot which demonstrates a customer name being out of sync.

[jbaxleyiii]

➤ mitjade commented:

Same problem for me.

[jbaxleyiii]

➤ Niklas von Hertzen commented:

Experiencing same issue, the error prop never seems to return anything else than undefined, and when a component that was supposed to have an error gets unmounted, it throws an Unhandled error error right after.

Using apollo-client 2.0.1 and react-apollo 2.0.0

[jbaxleyiii]

➤ Nepomuk Seiler commented:

This test should validate that this actually works. Is the error field only for non-graphql errors (e.g. network failure, 5xx responses, etc.)?

[jbaxleyiii]

➤ Jim Kynde Meyer commented:

As far as I can tell, the test doesn't cover the optimization logic in render: https://github.com/apollographql/react-apollo/blob/master/src/graphql.tsx#L604-L622

It focuses mainly on componentWillReceiveProps which is no guarantee that the wrapped component will be given the right props during render.

[jbaxleyiii]

➤ mitjade commented:

With apollo-client 2.0.2 the error now get's correctly set for me, but I still get the Unhandled error error right after.