GithubHelp home page GithubHelp logo

Comments (6)

arahansen avatar arahansen commented on May 3, 2024

also, I just realized that PR was merged only an hour ago! I hope I don't come across as impatient. My workaround works pretty well for my use case for the time being.

from apollo-link.

evans avatar evans commented on May 3, 2024

@arahansen can you post an error log from your build?

Thank you for posting so quickly!

from apollo-link.

arahansen avatar arahansen commented on May 3, 2024

The error was essentially UglifyJS from webpack trying to parse es6 code because apollo-link was consuming it directly.

It was failing on this line: https://github.com/zenparsing/zen-observable/blob/master/src/Observable.js#L19

from apollo-link.

evans avatar evans commented on May 3, 2024

@arahansen got it I manually published. Lerna seemed not to pick up apollo-link even though it created the tag. The build should run now

from apollo-link.

evans avatar evans commented on May 3, 2024

@arahansen Still failing. Working on a typescript implementation of zen-observable, since I don't think there is an easier way of getting rid of the git dependency #14 and keeping the typings.

Please let me know if you have other ideas

from apollo-link.

evans avatar evans commented on May 3, 2024

Fixed with #23

from apollo-link.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.