Version compatibility issue with ReasonApolloMutation.re ? about reason-apollo

[rickyvetter]

Yeah agree that removing annotations in implementation is probably the easiest and most idiomatic way to do this.

[yawaramin]

The issue was discussed in Discord and, as I understand it, this compile error is happening because of a ReasonReact JSX bugfix that was shipped in bs-platform 7.1.0. This was fixing an unsoundness issue (cf. @rickyvetter) and was considered important to get out the door.

The compile error pasted above comes from this piece of code:

reason-apollo/src/graphql-types/ReasonApolloMutation.re

Line 129 in f069289

~variables: Js.Json.t=?,

Personally, my recommendation would be to get rid of type annotations from values and functions in implementation files. I consider this to be more idiomatic anyway. Plus it should work across both BuckleScript 7.1.0 and earlier. It would look like this:

// src/graphql-types/ReasonApolloMutation.re

[@react.component]
  let make =
      (
        ~variables=?,
        ~onError=?,
        ~onCompleted=?,
        ~children,
      ) => ...

I realize people will need type annotations–they can be put in the corresponding interface files, e.g.

// src/graphql-types/ReasonApolloMutation.rei

[@react.component]
let make:
      (
        ~variables: Js.Json.t=?, // No option needed! :-)
        ~onError: apolloError => unit=?,
        ~onCompleted: unit => unit=?,
        ~children: (apolloMutation, renderPropObj) => React.element,
      ) =>
    React.element;

And so on.

cc @sgrove @idkjs

[idkjs]

Where are we fixing this? Is on https://github.com/idkjs/reason-apollo/tree/bs_platform_7? Or master?

[yawaramin]

@idkjs in this repo itself. See my comment above (code examples have file names).

[idkjs]

I guess master since its on bs-platform 7 already.

[yawaramin]

Oh sorry you were asking about the branch. I would say master.