GithubHelp home page GithubHelp logo

[Request] Dark mode about contactdiary HOT 8 CLOSED

apozas avatar apozas commented on September 3, 2024 8
[Request] Dark mode

from contactdiary.

Comments (8)

apozas avatar apozas commented on September 3, 2024 1

How does this look?

from contactdiary.

apozas avatar apozas commented on September 3, 2024 1

It is my intention that it does, although I am still struggling with it. While I know how to make it to follow it (it's a matter of setting in the appropriate place the flag MODE_NIGHT_FOLLOW_SYSTEM), I haven't figured out yet how to read which is the system-wide choice. Right now, I need this in a few places. EDIT: Found it

Regarding the borders, this version has no borders between entries, only between days. I'm open to thoughts, so thanks for the feedback.

from contactdiary.

revuwa avatar revuwa commented on September 3, 2024 1

Even if late, I just wanted to thank you @apozas very much for the (fast and good looking) fulfillment of my wish ❤️

from contactdiary.

apozas avatar apozas commented on September 3, 2024

I totally agree, as I am the first one experiencing this. It will be added soon, although maybe not in the very next version.

from contactdiary.

igor-cali avatar igor-cali commented on September 3, 2024

@apozas I made some experiments to add the dark theme. One problem I encountered is that some layouts call for drawables with light colours .
At first glance, it is not clear to me what those light colours are for. If really necessary, this would lead to additional code.

E.g. selector.xml and rounded_corner.xml.

Thanks in advance for your hints.

from contactdiary.

apozas avatar apozas commented on September 3, 2024

No, thank you for giving it a shot :)

selector.xml contains a call to colorSelected (in colors.xml), that is the color of the background when in multiple selection mode. See the example below.

rounded_corner.xml defines the box behind the descriptions of the buttons after the FAB is uncollapsed. See the following figure

I have realized that I can eliminate the stroke without consequences (and I'll do it in a subsequent commit), but solid is required (it is the color of the background) and ideally it would match the background color of the list.

Let me know if there's anything else you need to know.

from contactdiary.

GenosseFlosse avatar GenosseFlosse commented on September 3, 2024

Does this dark mode respect the system wide dark mode setting?
EDIT: Are there some borders between entries? Having no line of another color between entries is irritating for me.

from contactdiary.

apozas avatar apozas commented on September 3, 2024

Having received no complaints (:stuck_out_tongue_closed_eyes:) one week after this version appeared on F-Droid, I'm closing this issue. Feel free to reopen if anything comes up.

from contactdiary.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.