Comments (7)
We've never implemented support for it, and in practice the plaintext upgrade functionality was essentially never deployed. In fact, it's being removed from the revision of the specification for HTTP/2 because of how little it was used.
from swift-nio-http2.
I am trying to do that manually, and streamChannel does not get initialized with my final handler. But handshake and settings exchange are successful.
from swift-nio-http2.
Can you show me what your pipeline setup looks like?
from swift-nio-http2.
I have something like this:
self.deleteAllHandlers(context)
context.channel.configureHTTP2Pipeline(mode: .server) { streamChannel -> EventLoopFuture<Void> in
print("configureHTTP2Pipeline triggered")
return streamChannel.pipeline.addHandler(HTTP2FramePayloadToHTTP1ServerCodec(normalizeHTTPHeaders: true)).flatMap { () -> EventLoopFuture<Void> in
streamChannel.pipeline.addHandler(PlainHTTPHandler(fromHTTP2: true)).flatMap { () -> EventLoopFuture<Void> in
streamChannel.pipeline.addHandler(ErrorHandler())
}
}
}.flatMap { (_: HTTP2StreamMultiplexer) in
context.channel.pipeline.addHandler(ErrorHandler())
}
from swift-nio-http2.
And to be clear, this is attempting to do plaintext upgrade?
from swift-nio-http2.
Yes, this is a plaintext upgrade from HTTP/1.
from swift-nio-http2.
Ok, without changes to the core state machine this cannot work. HTTP/2 has a defined upgrade pattern from HTTP/1.1 that requires passing a SETTINGS frame in via a header, and consuming the body payload from the HTTP/1.1 request. You'd need to update the HTTP2Handler
and associated state machines in order to get this to work.
from swift-nio-http2.
Related Issues (20)
- HPACKHeaders.peekPseudoHeader allocates awkward temporary array
- HTTP2ChannelHandler.wroteFrame is never returned to false
- Consider returning [Substring] from HPACKHeaders.subscript(canonicalForm:)
- Provide API for adding pseudo headers to HPACKHeaders
- OutboundFlowControlBuffer probably allocates unnecessarily
- Improve performance of `Substring._trimWhitespace()` HOT 1
- Suppress writes triggered by EOF reads
- Remote pushes with invalid headers leave a stream dangling
- Push latest versions to CocoaPods? HOT 1
- `NIOHTTP2Handler` should handle `ChannelShouldQuiesceEvent` HOT 1
- Reconsider implementation of Equatable and Hashable for HPACKHeaders HOT 2
- Remove @unchecked Sendable when NIOCore adopts Sendable
- Produce a better error when sending HEADERS on a quiesced connection
- StreamMap slow? HOT 7
- Failed assertion in change from 1.24.1 to 1.25.0 HOT 5
- The new HPACK header test for RemoveAll() fails on Android HOT 2
- Race condition causes header frame to be fired on HTTP2StreamChannel AFTER first data frame(s) HOT 3
- Content-Length in responses on HEAD method produce error HOT 3
- Support close mode when closing HTTP2StreamChannel HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from swift-nio-http2.