Rename `Mailbox` → `MailboxName`; change underlying storage about swift-nio-imap

[danieleggert]

@danieleggert any other instances where we NEED to preserve the non-decoded bytes even if we can correctly decode then?

Not that I can think of right now, but I’ll comment as I go through.

[weissi]

@danieleggert so you would not want us to decode it? We could the UTF7/8 decoding?

[weissi]

We have #10 right now to to that because we assumed that we can do a lossless decoding.

[danieleggert]

It’s important to preserve the non-decoded byte stream since that’s what we can round-trip.

The non-decoded byte stream is the identity of the mailbox, whereas the decoded is the user-displayable String.

The decoding would be great, too, but on second thought, that should probably be part of something else, since you’d want to split the MailboxName into components (based on the separator from the LIST response), and then transform each part as needed, i.e. basically turn (/, a/b) into ["a", "b"]. But for nested folders, we may only need / want to convert the last component or such.

[weissi]

Thanks v much @danieleggert , that makes sense. @Davidde94 let's preserve MailboxName as ByteBuffer then, alongside a comment that is basically what Daniel writes :).

@danieleggert any other instances where we NEED to preserve the non-decoded bytes even if we can correctly decode then?

[Davidde94]

Sounds good to me.

[weissi]

Thanks, commenting on #10