GithubHelp home page GithubHelp logo

Comments (7)

Lukasa avatar Lukasa commented on August 12, 2024 1

Yup, that's exactly what it means.

In principle the mechanism to implement it should be simply to call .receive multiple times. I'm not 100% confident the code will handle that well, but that's how I'd go about starting out.

from swift-nio-transport-services.

edwellbrook avatar edwellbrook commented on August 12, 2024

Hi @weissi! Just came across this in one of my own projects and have some motivation to fix it.

This would be my first time contributing to to an swift-nio project, though I have some basic understanding of how things work. Some guidance would be appreciated...

Could you suggest what a good user-facing API would look like for configuring these values? Perhaps another option under NIOTSChannelOptions?

Thanks!

from swift-nio-transport-services.

weissi avatar weissi commented on August 12, 2024

Hi @edwellbrook , awesome, and welcome! And thank you for your PR, I'll leave comments regarding your PR on the actual PR.

Were you separately from your existing PR (which configures the maximum read size) interested in working on maxMessagesPerRead?

from swift-nio-transport-services.

edwellbrook avatar edwellbrook commented on August 12, 2024

Unfortunately I don't have much need for maxMessagesPerRead so I can't budget the time for it right now. If my existing PR needs updating I might be able to quickly fit this in though!

Not super familiar with maxMessagesPerRead so would need a suggestion on how it's supposed to work and should be implemented.

from swift-nio-transport-services.

weissi avatar weissi commented on August 12, 2024

@edwellbrook totally up to you. I fully understand if you can't budget the time. Ping me if you'd like an explanation of what it does exactly and how we could implement it.

from swift-nio-transport-services.

edwellbrook avatar edwellbrook commented on August 12, 2024

@weissi It's looking like I may need maxMessagesPerRead after all (if I'm understanding it correctly).

Does it refers to the number of messages an InboundChannelHandler will receive from a read call before needing to call read again? i.e. setting maxMessagesPerRead to 1 would mean an InboundChannelHandler needs to call read for each message?

If that's right... I'd love a suggestion on how to implement it.

Cheers!

from swift-nio-transport-services.

edwellbrook avatar edwellbrook commented on August 12, 2024

@Lukasa Thanks! Will take a look tomorrow morning.

from swift-nio-transport-services.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.