Add ability to attach protocols to generated models about swift-openapi-generator

[simonjbeaumont]

This is similar to #383, where could conceivably attach arbitrary conformances or macros that are stated in the config file and it be up to the adopter to ensure these are available in their project.

It wouldn't be too different from the ability we have know to express additionalImports.

[czechboy0]

That's true, @simonjbeaumont, and the macro itself would contain the logic for how to e.g. implement Identifiable, instead of the generator having to know how to do it. I like that.

[czechboy0]

Hi @armintelker,

all generated types already conform to Equatable, as we generate the Hashable conformance (which includes Equatable).

Identifiable, on the other hand, is tricky, as it's not clear what the id property should return for arbitrary schemas. What would be your expectation?

[armintelker]

Hey, thanks for the quick response.
I have overseen that the DTO is already conforming to Hashable. This makes, of course, everything a lot easier. So my request gets kind of needless.
Indeed the Identifiable protocol suggestion would be more like a "nice to have".
I could imagine that the generator could add the Identifiable to the model as soon it sees a property id exists that also conforms to the constraint of the protocol.

[czechboy0]

I could imagine that the generator could add the Identifiable to the model as soon it sees a property id exists that also conforms to the constraint of the protocol.

In theory yes, but my first instinct is that this would be considered out of scope of an OpenAPI generator. I think a separate build plugin that processes your Swift code and adds Identifiable to any struct that has an id property would be more appropriate, and more maintainable. This is a feature that would be useful outside of the OpenAPI context.

[shadone]

+1 to this. In my use case it would also be useful to have ability to add Identifiable conformance to some types. There is literally no other way to do this - I have a library that uses swift-openapi-generator to generate the type and expose them publicly.

It would be nice if Swift allowed to add public conformance to a protocol in an extension:

public extension Components.Schemas.SortType: Identifiable { // compiler error: 'public' modifier cannot be used with extensions that declare protocol conformances
    public var id: String { rawValue }
}

Unfortunately this is not possible in Swift, so the only solution I can see is to solve it in the openapi generator.

[czechboy0]

Hi @shadone,

does this work?

extension Components.Schemas.SortType: Identifiable {
    public var id: String { rawValue }
}

(without the public modifier on the extension, only on the id property).

[shadone]

<deleted previous content> I completely misunderstood what czechboy0 was saying

That work indeed, thanks @czechboy0 ! To be honest I had no idea this is possible, despite years of writing Swift code. And to be honest I do not understand why this works (does the SortType publicly conform to the protocol here or just the "shape" of the protocol)

But it works great, thanks!

[czechboy0]

does the SortType publicly conform to the protocol here or just the "shape" of the protocol

I believe the visibility of the conformance is always derived from the visibility of the extended type and the protocol, i.e. there is no way to privately conform a public type to a public protocol.

But to get more details, starting a thread on the Swift Forums might be a good next step, if you're interested in the lower level compiler details.