Raise specific exceptions? about turicreate

[znation]

@delirious-lettuce Thanks, I see! I suspect this may have worked at some point in Python 2 but perhaps it never did.

I would use RuntimeError to wrap all of these strings. Please feel free to submit a PR with that. Thanks!

[znation]

@gustavla Something we should do as part of the fix for #2 ? I haven't tested this but I suspect Python 3 is less happy about using strings as exception values than Python 2.

[delirious-lettuce]

@znation ,

I used Python 2 for the first comment but this shows both. This is a TypeError in both versions.

Python 2.7.12 (default, Nov 20 2017, 18:23:56) 
[GCC 5.4.0 20160609] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> raise "test"
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: exceptions must be old-style classes or derived from BaseException, not str


Python 3.5.2 (default, Nov 23 2017, 16:37:01) 
[GCC 5.4.0 20160609] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> raise "test"
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: exceptions must derive from BaseException

[delirious-lettuce]

I just wasn't sure what specific exception you guys wanted raised so I didn't send a PR.

[delirious-lettuce]

@znation ,

You might be right, 2.7.12 is the lowest Python version I have tested it with but it may have been different earlier (2.6 maybe?).

I am just about to send a tiny PR right now but then I will fix this one ASAP (with RuntimeError).