Removing ActionDispatch::RemoteIp middleware crashes application when using AppSignal about appsignal-ruby

[tombruijn]

This has been changed to the ActionDispatch::DebugExceptions middleware in #286. Same problem there. If you remove that middleware the same problem occurs.

[tombruijn]

Timeboxed in an hour: look if we can detect which middleware is present at the time we add our middleware to the proxy. If not, close the issue and this becomes a requirement for AppSignal to work in Rails.

[thijsc]

We tried to reproduce this and could not with the latest appsignal gem and Rails 5. We now insert the middleware after ActionDispatch::DebugExceptions. We weren't able to break the insertion.

[tombruijn]

Correct, the middleware we depend on now is ActionDispatch::DebugExceptions. Same issue exists when removing that middleware. This issue was from before that.

As discussed we should add a config option insert_after_rails_middleware or something, so that users can configure which middleware it should be added after themselves.

As issue week is already closed I'll move it to longterm.

[tombruijn]

Will probably be fixed with #159
where we will be at the top of the middleware stack so that we don't depend on other middleware to be injected at a specific location in the stack