Basic Rack integration broken? Documentation outdated about appsignal-ruby

[1st8]

I think the problem is rather simple:
When an exception happens in the @app.call(env) part, it is added to the transaction as usual.
Since the exception is then re-raised, no StreamWrapper instance is returned, and the transaction has thus no way of ever completing.

I think adding something like this after line 38 would solve the problem:

Appsignal::Transaction.complete_current! if transaction.has_error?

Unfortunately I can't find anything like Appsignal::Transaction#has_error, otherwise I would've submitted a PR.

[thijsc]

This was an oversight on our part, we removed the Rack listener but have not provided a replacement yet. Appsignal::Rack::StreamingListener is intended for situations where you keep a Rack response open for long periods of time. I'll have a look at reinstating the Rack listener later this week.

Is this a custom Rack app? Or do you use a framework we don't support out of the box yet?

[1st8]

Whoops, I forgot about this.
I am using Hanami, formerly Lotus.rb, but a plain Rack middleware is my preferred solution.
The referenced PR #99 resolved my issue and should help making the StreamingListener usable for non-streaming use-cases in general.
Does my explanation above and the referenced solution sense for you?

[thijsc]

Thanks for the pull! The streaming listener is intended for situations where you keep a stream open for longer periods of time. I've added a replacement for the old Rack instrumentation in #103. Would that fix your use case?