GithubHelp home page GithubHelp logo

Comments (4)

MaximumMaxxx avatar MaximumMaxxx commented on June 24, 2024

Also just noticed that this issue only seems to happen in ff. Chrome works as expected

from console.

MaximumMaxxx avatar MaximumMaxxx commented on June 24, 2024

Relevant discord messages too:
https://discord.com/channels/564160730845151244/1102936099745177700/1125937233636114432
https://discord.com/channels/564160730845151244/1102936099745177700/1123339779627556986

from console.

MaximumMaxxx avatar MaximumMaxxx commented on June 24, 2024

I think I've narrowed down the problem to this part of the regex

^(?!-)[A-Za-z0-9-]+([\-\.]{1}[a-z0-9]+)*\.[A-Za-z]{2,6}$
                                                     ^

Any tld longer than 6 characters doesn't get matched. Which works fine except that some tlds are longer than 6 characters as seen with .contractors. The longest is in fact 24 (XN--VERMGENSBERATUNG-PWB), although it could theorertically be up to 63 characters

image

image

The solution would be to bump the limit to either 24 or 63

^(?!-)[A-Za-z0-9-]+([\-\.]{1}[a-z0-9]+)*\.[A-Za-z]{2,63}$
                                                     ^

Although that actually wouldn't work for all domains since "-" is not included in the filter, so actually adding a dash would allow proper matching of big domains

^(?!-)[A-Za-z0-9-]+([\-\.]{1}[a-z0-9]+)*\.[A-Za-z-]{2,63}$
                                                 ^

from console.

stnguyen90 avatar stnguyen90 commented on June 24, 2024

Closing as a duplicate of appwrite/appwrite#5273

from console.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.