GithubHelp home page GithubHelp logo

Comments (2)

ar1st0crat avatar ar1st0crat commented on August 17, 2024

Hi, ApplyTo() methods were initially designed to carry out the convolution, so the output length is signal_length + filter_size - 1 (although in case of diff equation the length is indeed identical to the input length).

First of all, you say you use IIR filter. It means that the impulse response (the filter kernel) has infinite length. For classic OverlapSave implementation it needs to be finite. In NWaves code the impulse response is just truncated at some particular size, i.e. the result can be close to what you expect, but still not precisely correct. So, did you try just auto mode (i.e. not a difference equation)? I.e. DiscreteSignal pOut = MyFilter.ApplyTo(p); or DiscreteSignal pOut = MyFilter.FilterOnline(p);?

If both still produce problems, can you try to use IirFilter64 class (with double precision and call the same methods above?


If you stick with OverlapSave then there are possible solutions (I assume you'll prefer the first one, but maybe 2 and 3 are also ok):

  1. use OlsBlockConvolver and FilterOnline() method that processes the signal sample in a loop (just like in online scenario):
// not really correct because yours is IIR filter!
var length = 128; // we'll truncate impulse response by this length
var olsFilter = new OlsBlockConvolver(MyFilter.Tf.ImpulseResponse(length), 512);
var filtered = olsFilter.FilterOnline(signal);
// 512 is the FFT size, should be power of 2: 512, 1024, 2048, etc. (often it's ~4*filter_size)
  1. simply ignore last filter_size - 1 samples

  2. copy (if you don't care much about the memory): filteredSignal.First(signal.Length)

from nwaves.

MucAcoustics avatar MucAcoustics commented on August 17, 2024

Lesson learnt! Thanks a lot for your hints. The IirFilter64 solution does the job. It runs MyFilter.ApplyTo(p), MyFilter now based on an IirFilter64 resp. FilterChain64, without any problems. Straightforward and stable. The default setting "Auto" for the FilterMethod is just as right. Great!

from nwaves.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.