Comments (6)
@MrIvanPlays and @Jikoo:
transactionAmount
->amount
Prefixing amount
with transaction
whilst it is already clearly inside a transaction namespace (the EconomyTransaction
class) is verbose and pointless.
economyTransactionType
->type
Identical reasoning to the above, though this is even more verbose than the transaction amount name.
currencyID
->currencyId
As Jikoo mentioned - inconsistency. Lowercase the 'd'.
from treasury.
from treasury.
Why?
from treasury.
Not opposed to these, but is it a large enough concern to bother? I do prefer Google's style of lowercasing subsequent letters in abbreviations. Is that specifically an inconsistency across the project?
from treasury.
What you're doing here is creating an elephant from a fly.
from treasury.
What you're doing here is creating an elephant from a fly.
yup - I'm big on quality control. 😁
Regardless, would you be fine with the proposed changes?
from treasury.
Related Issues (20)
- Expanding #246
- General Javadoc Improvements
- `Response`: add method to fail with a given exception HOT 6
- `Account`: Change the return type of `retrievePermissionsMap` HOT 7
- Review API methods which do not return a Future+Response type. HOT 13
- `Currency`: Should we map display names against locales? HOT 3
- Responses vs Exceptions - differentiate and debate HOT 20
- `Account`: Rename `setPermission`, `hasPermission` to use a plural HOT 3
- Review methods which return TriStates but do not utilise all three possible states HOT 25
- `Account`: add another `setPermissions` method which accepts a `Map<perm, state>` HOT 2
- Change currency identifier to NamespacedKey HOT 6
- EconomyTransactionResult HOT 6
- Add abstract TreasuryException#getMessage(Locale) method
- Publish to Hangar HOT 5
- Last thoughts on Treasury v2's API? YOUR OPINION is wanted! HOT 10
- Write API Documentation in Wiki HOT 17
- Strip colours out of logging HOT 1
- Breaking Change Proposals ('Treasury v3')
- New Author HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from treasury.