Bug: Non-deterministic generation when combining SMZ3 and The Legend of Zelda about archipelago

[PoryGone]

@lordlou @Rosalie-A @t3hf1gm3nt

[t3hf1gm3nt]

I have determined at the very least that there is an issue of non-deterministic behavior in TLOZ's level 9 junk fill. Specifically with the use of random.choice here: https://github.com/ArchipelagoMW/Archipelago/blob/main/worlds/tloz/ItemPool.py#L139 as it will grab a different group of filler items even with the same seed. I will need to do a bit more testing to determine that this is the only issue, but my preliminary testing is showing that this might be the solely an issue with TLOZ and not with SMZ3, and will also come up with and PR a solution this weekend.

[ScipioWright]

I have determined at the very least that there is an issue of non-deterministic behavior in TLOZ's level 9 junk fill. Specifically with the use of random.choice here: https://github.com/ArchipelagoMW/Archipelago/blob/main/worlds/tloz/ItemPool.py#L139 as it will grab a different group of filler items even with the same seed. I will need to do a bit more testing to determine that this is the only issue, but my preliminary testing is showing that this might be the solely an issue with TLOZ and not with SMZ3, and will also come up with and PR a solution this weekend.

Instead of doing random = world.multiworld.random, do random = world.random -- that should fix it

Definitely doesn't help that SMZ3 also uses multiworld.random all over the place -- that's probably contributing to this in some fashion

[Mysteryem]

The way I identified this issue was to compare the location of all progression items between generations, so I paid no attention to filler items if that's something that's been identified as an issue.

I modified the end of the generator to output the location of every progression item and what that item is into a line in a file whose filename is unique to the combination of the seed and the worlds in the multiworld.

If the file already exists when preparing to output to it, the progression items from the current generation are compared against each line in the file and if none of the lines match the current generation, then a new line is written for the current generation.

With this setup, I could put a unique combination of template yamls in the Players folder and spin up generation with the same seed a bunch of times. If the debug output file for that combination ever had more than one line in it, then that combination of yamls had non-deterministic generation.

I used this to bisect, starting with generation that included every template yaml, until I could find which worlds were causing the generation to be non-deterministic.

[t3hf1gm3nt]

Did what I could on TLOZ's end with #3670. lordlou will still need to look into whats going on for SMZ3