Comments (6)
I have to thank you for your work. This repo inspire me to create a plugin in Obsidian.md, and I shared this repo link inside the readme.md as source.
If I achieve another kind of cell (calendar, image...) I will share it here too!
https://github.com/RafaelGB/obsidian-db-folder
from editable-react-table.
Hi Jeff,
Thank you for your kind words. I'm happy that you're enjoying this project and would like to extend it.
As the code is currently, I believe the Table
component can be published as a module and re used in other projects. There are a few things to be mindful of when making this change:
- State management is completely outside the
Table
component and currently usesuseReducer
. All the code is written with this in mind, so you might need to make changes if you wish to use a different state management tool and/or move state management inside theTable
component itself. I see that you've chosen to introduce theTableWrapper
component and bring state management into the module itself. - The project uses an older version of Vite and so build is done using Rollup. Vite has since moved to using Esbuild which is faster, so that is something to be explored.
- There are no provisions to change the styling. All styles are written using plain CSS, so this might become an issue when integrating within a larger project with its own style system.
- Finally, there are no tests in the project. This is an area I'm unfamiliar with, however I strongly believe tests would be required for robustness.
I'll be happy to discuss these issues further and to integrate these changes into the project. Feel free to create a PR/more issues with ideas and questions!
from editable-react-table.
Thanks for the feedback @jeff-r-koyaltech @RafaelGB @joseph-vedadi ! Will be using #13 to track creating a package.
from editable-react-table.
Thanks, this is helpful and mostly inline with how I felt after reading the code base. We have a pretty strong unit testing practice at Koyal Tech, and will endeavor to contribute some basics in that regard. 👍
Just so you're aware, I did an MVP to get it modularized and able to import, but I know further enhancements will be required before it is useful enough to merge back in.
https://github.com/koyal-tech/editable-react-table
(PR 1 might be of interest at a quick glance.. koyal-tech#1 )
https://www.npmjs.com/package/@koyal-tech/editable-react-table
from editable-react-table.
As I promise, I dev the Calendar column type using react-calendar npm dependency feel free to check it =)
from editable-react-table.
Is it possible to create an installable package?
Great package, but hard to use 🥇
from editable-react-table.
Related Issues (11)
- Error in the Getting started > 2-Install dependencies and build. HOT 2
- Explore how to release this project as a package
- Keep CodeSandbox demo up-to-date with repo
- Record a new demo for README
- Integration example with an SDK?
- Missing search
- App doesn't render on Safari
- Select popup is hidden behind window
- How can I easily integrate into existing project? Possibility to make a npm package? HOT 2
- npm start HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from editable-react-table.