Chrome issue about node-archiver

[danmilon]

It must be a bug in your application code serving the file. What are the headers? Is Content-Disposition set?

I'm using express:

archiver.finalize(function(err, written) {
  if (err) {
    throw err;
  }
  res.header('Content-Disposition', 'attachment; filename='+req.params.file);
  //res.header('Content-Type', 'application/zip'); // also tried this
  res.header("Content-Type", "application/octet-stream")
  //console.log(written + ' total bytes written');
  res.end();
});

Issue only encountered in Chrome (Chrome 27.0.1453.93).

[danmilon]

Could you provide the whole test so I could try it?

I can give you a link:
http://alexduloz.github.io/picnicc.bootstrap/customize.html
Posting code that you could use will take me time.

[danmilon]

There's no Content-Disposition nor Content-Type.

$ curl -s -D - https://picni.cc/builds/alexduloz/picnicc.bootstrap.zip/4d0552662f651878e36000ac5a2485ce/picnicc.bootstrap.zip -o /dev/null
HTTP/1.1 200 OK
Server: cloudflare-nginx
Date: Wed, 05 Jun 2013 14:44:17 GMT
Transfer-Encoding: chunked
Connection: keep-alive
access-control-allow-origin: *
access-control-allow-headers: X-Requested-With
x-content-type-options: nosniff
x-powered-by: picni.cc
CF-RAY: 79da3d410b604a3

So the code posted above should work, correct? I checked on nodejitsu, the correct snapshot is active. Anyway, thanks for the kind help.
:)

[danmilon]

Well, I don't have the code to tell you, but there's surely something wrong with it, since the headers sent are not correct, as shown above.

[ctalkington]

hum wouldn't you pass the headers at beginning?

How embarrassing...
All I had to do was send the correct headers before anything else. I somehow misunderstood the .finalize method.

res.header('Content-Disposition', 'attachment; filename=some-file-name.zip');
res.header('Content-Type', 'application/zip');

[danmilon]

No worries :) Feel free to close the issue.