Comments (2)
requires a follow up commit:
commit 4affa75a90d2455c81087b930126ad7adfd019f0
Author: Adam Jackson <[email protected]>
Date: Thu Nov 19 12:21:08 2015 -0500
xnest: Fix needless build dependency on xcb-util-keysyms
This was added in:
commit 43014795087a0a8774dd9687f5967329b15f06a2
Author: Olivier Fourdan <[email protected]>
Date: Mon Jan 5 16:44:22 2015 +0100
Synchronize capslock in Xnest and Xephyr
Which is fine if you're building both, but if you don't happen to have
xcb-util-keysyms' headers installed Xnest will configure as enabled but
fail to build.
Fortunately <X11/X.h> has a corresponding #define, so use that instead.
Signed-off-by: Adam Jackson <[email protected]>
Reviewed-by: Olivier Fourdan <[email protected]>
diff --git a/hw/xnest/Keyboard.c b/hw/xnest/Keyboard.c
index 7ee7a7c..85deaba 100644
--- a/hw/xnest/Keyboard.c
+++ b/hw/xnest/Keyboard.c
@@ -22,7 +22,6 @@ is" without express or implied warranty.
#include <X11/X.h>
#include <X11/Xproto.h>
-#include <xcb/xcb_keysyms.h>
#include <X11/keysym.h>
#include "screenint.h"
#include "inputstr.h"
@@ -252,7 +251,7 @@ xnestUpdateModifierState(unsigned int state)
for (key = 0; key < MAP_LENGTH; key++)
if (keyc->xkbInfo->desc->map->modmap[key] & mask) {
- if (mask == XCB_MOD_MASK_LOCK) {
+ if (mask == LockMask) {
xnestQueueKeyEvent(KeyPress, key);
xnestQueueKeyEvent(KeyRelease, key);
}
@@ -270,7 +269,7 @@ xnestUpdateModifierState(unsigned int state)
for (key = 0; key < MAP_LENGTH; key++)
if (keyc->xkbInfo->desc->map->modmap[key] & mask) {
xnestQueueKeyEvent(KeyPress, key);
- if (mask == XCB_MOD_MASK_LOCK)
+ if (mask == LockMask)
xnestQueueKeyEvent(KeyRelease, key);
break;
}
from nx-libs.
I am not fully sure, if the above patches are needed for nxagent. With some quick tests, it seems that CAPS lock is kept in sync between local X and nested X session.
However, we have an with the NUMLOCK key, which may be similar here (needs to be verified): with NUMLOCK, some session managers manipulate the NUMLOCK state (e.g. MATE's session manager). In the remote session NUMLOCK is then enabled, whereas the keys' functionality is that of a keyboard with NUMLOCK disabled.
When disabling NUMLOCK via keyboard then, it actually gets enabled and vice versa.
So, what we need to check is: Is software manipulation of CAPS lock accurately reflected in the nested and the local X11 session.
from nx-libs.
Related Issues (20)
- Just another questions about shadow mode. HOT 4
- Error - X2Go Desktop Bindings installation HOT 1
- nxagent -v starts fullscreen session
- Unexpected fullscreen on reconnect with SDL applications
- Resizing breaks after multiple xrandr calls HOT 5
- Which repo to use for x2go? HOT 8
- Empty screen when starting an nx session from another nx session on branch 3.6.x (2023/05/10) HOT 1
- nxagent 3.5.99.26 does not work on Alpine. HOT 9
- Build error depending on $VERBOSE flag HOT 5
- nxagent: Filter ACPI events HOT 7
- run-nxproxy2nxagent* test scripts yield black window HOT 1
- Rootless mode: Qt applications do not exit HOT 15
- x2goclient wrong windows size by default HOT 1
- Vulnerability Report: Path traversal and Code Execution in dlopen via environment variable HOT 1
- Segfault in libXcompshad
- Stop using gethostbyname, deprecated in glibc
- '. replace.sh' fails for POSIX shells (e.g. Bash as 'sh')
- Random parallel build failures HOT 10
- nx-libs.spec file license says GPLv2+, should be GPLv2 (only)
- Composite not working? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nx-libs.