Comments (3)
I did think about mentioning it just recently.
But just like with cutting all the things out of the requests file, I was left with the "maybe too much" feeling. It currently works as is without actual internet permission.
But as you now mention it
might remove 'candybar.lib.activities.CandyBarCrashReport' while at it (maybe - optional)- those 2 are sadly not exposed to App Ops, therefore no quick testing from me
- given that requests are handed over to an email client of choice, not knowing the network state at all shouldn't matter (e-mail clients incapable of basic offline buffering might still cause issues, assuming the icon request logic makes/made use of it)
- the storage permission ≤28 probably still has some use linked to requests ? (Or potentially Wallpaper related stuff)
- there's probably a bunch more stuff that could in theory be removed
- might also just still be there as required by an library that's still in use
So just like with bumping up that target SDK, go for it and see if it breaks.
from arcticons.
Crash reporting is actually useful, so I don't see removing that one (the user still has to send the report to me).
from arcticons.
As I've actually never had to use it and given the fully FOSS move I just assumed those were just remains.
If users actually use it that's obviously reaching a broader user base than hoping for someone to mention it here on GitHub.
Still leaves the question if those 2 permissions are currently used to warn/prevent the user from completing something that (potentially) won't work without Internet connection.
Should this be the case, where does the line get drawn in terms of guidance and "pointing out the obvious" vs permission minimalism.
from arcticons.
Related Issues (20)
- Bring back the old LibreTube Icon HOT 2
- InnerTune App is no longer updated - Request HOT 1
- Allow time widget to open non-standard clock app HOT 2
- Website not deployed with newest version HOT 1
- Request Dashboard not mentioned in new Docs HOT 2
- f-droid not updated since 9.6.5 HOT 3
- 3 FOSS apps icon request HOT 1
- Request Site on Mobile HOT 1
- Use GitHub to build APKs for releases, instead of me on my local pc HOT 2
- Depreciated Code HOT 3
- Size increase by contributor image assets
- Documentation update ? HOT 3
- [IDEA] Webp icons? HOT 3
- Bug app missing in request page HOT 15
- Requesting For Visual Improvements Of The Icons! HOT 2
- Making Icon Request For Missing Icons HOT 1
- Android 12 is not required for Arcticons You HOT 2
- InnerTune (Arturo 254) Rebranded HOT 7
- Kvaesitso Material You HOT 2
- Material You Kvaesitso HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from arcticons.