GithubHelp home page GithubHelp logo

Comments (3)

TotallyAvailable avatar TotallyAvailable commented on September 22, 2024

I did think about mentioning it just recently.
But just like with cutting all the things out of the requests file, I was left with the "maybe too much" feeling. It currently works as is without actual internet permission.

But as you now mention it

  • might remove 'candybar.lib.activities.CandyBarCrashReport' while at it (maybe - optional)
  • those 2 are sadly not exposed to App Ops, therefore no quick testing from me
  • given that requests are handed over to an email client of choice, not knowing the network state at all shouldn't matter (e-mail clients incapable of basic offline buffering might still cause issues, assuming the icon request logic makes/made use of it)
  • the storage permission ≤28 probably still has some use linked to requests ? (Or potentially Wallpaper related stuff)
  • there's probably a bunch more stuff that could in theory be removed
  • might also just still be there as required by an library that's still in use

So just like with bumping up that target SDK, go for it and see if it breaks.

from arcticons.

Donnnno avatar Donnnno commented on September 22, 2024

Crash reporting is actually useful, so I don't see removing that one (the user still has to send the report to me).

from arcticons.

TotallyAvailable avatar TotallyAvailable commented on September 22, 2024

As I've actually never had to use it and given the fully FOSS move I just assumed those were just remains.
If users actually use it that's obviously reaching a broader user base than hoping for someone to mention it here on GitHub.
Still leaves the question if those 2 permissions are currently used to warn/prevent the user from completing something that (potentially) won't work without Internet connection.
Should this be the case, where does the line get drawn in terms of guidance and "pointing out the obvious" vs permission minimalism.

from arcticons.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.