GithubHelp home page GithubHelp logo

Comments (8)

xenei avatar xenei commented on September 28, 2024

I saw that you added json output rather than txt, but if possible can you make the Json output be more like this -
asd
Where there is both Original JP line and translated line for future QC and editing.
Here's a python script reference that makes json outputs like that -
Link
Only if possible, thank you.

from vntranslationtools.

AtomCrafty avatar AtomCrafty commented on September 28, 2024

Using the Japanese text as dictionary keys sounds like a recipe for desaster... It will fail as soon as any text appears twice and also the order is not necessarily preserved.

from vntranslationtools.

arcusmaximus avatar arcusmaximus commented on September 28, 2024

Support implemented. I didn't test it ingame, so let me know if everything works (line breaks, choice screens...)

As @AtomCrafty wrote, using messages as dictionary keys is a bad idea because there will always be cases where a (proper) translator wants to have different translations for lines that are identical in the original.

from vntranslationtools.

xenei avatar xenei commented on September 28, 2024

Everything seems to be working, choices, text etc, but word-wrap is not working
The Line-break code should be \n , I tried both Mono and proportional, but none seems to make any difference
Choices is also fine -
image

from vntranslationtools.

arcusmaximus avatar arcusmaximus commented on September 28, 2024

Wordwrapping added (monospace), please try again.

from vntranslationtools.

xenei avatar xenei commented on September 28, 2024

Unfortunately, it still doesn't seem to be working, decreasing or increasing Monospace char value doesn't make any difference
Though manually adding \\n to script seems fine

from vntranslationtools.

arcusmaximus avatar arcusmaximus commented on September 28, 2024

Forgot to also apply the wordwrapping to narration lines (only did it for dialogue at first)... Should work now.

from vntranslationtools.

xenei avatar xenei commented on September 28, 2024

It's working, thank you very much

from vntranslationtools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.