Documentation mismatch for `makeExecutableSchema` about graphql-tools

[helfer]

@migueloller yes, you're right of course. Thanks again!

The ones in the source code are correct. I will fix it (hopefully for good this time).

If you find any more issues, feel free to make a quick PR so we can just merge it.

[helfer]

@migueloller Oh, my bad. I mindlessly took out a positional argument in the middle that I don't think people should use any more 😬 . Should be fixed shortly.

[helfer]

@migueloller Please check if it's fixed now (make sure to clear the browser cache), and close the issue if it is. Thanks!

[migueloller]

I think the issue is that it expects named args instead of positional args. To make it work I had to pass in the arguments the following way:

const schema = makeExecutableSchema({
  typeDefs,
  resolvers,
});

[helfer]

Oh, that's right. So the arguments aren't actually positional, I just forgot to add the brackets. I got confused by my own documentation 😂

[helfer]

Should be fixed now. Thanks for pointing it out!

[migueloller]

Thanks!

[migueloller]

I forgot to mention/check that also the name variables are incorrect because now they're not positional, but named.

typeDefinitions should be typeDefs and resolveFunctions should be resolvers. See my comment above.

[migueloller]

I'm unsure if the correct names are the ones in the documentation or the ones in the source code.