Comments (8)
I see, in that case it would be more convenient if it were true by default. I'm definitely open to changing that, just go ahead and make a PR.
from graphql-tools.
No worries, if you're busy, I think someone else would be happy to do it! I'll label it as help wanted, but you can of course still do it if you like!
from graphql-tools.
@jbaxleyiii interesting. Do you have an example where returning undefined from a resolver is necessary and actually intended?
In my code, I generally return null
if child resolvers shouldn't run. When a resolver returns undefined, that was generally because I misspelled something, or tried to access a field that doesn't exist. allowUndefinedInResolvers = false
allowed me to find those bugs faster.
from graphql-tools.
@helfer for optional data its a lot easier in resolvers to return a possible undefined variable, rather than variable || null
.
https://github.com/NewSpring/Heighliner/blob/master/src/apollos/models/users/resolver.ts#L14
^^ that vs the rest of the resolvers where the return variable (for instance PersonId) could be undefined as it's not required
from graphql-tools.
Can do!
from graphql-tools.
@jbaxleyiii are you still interested in this? should be a relatively quick PR.
from graphql-tools.
🔔 ping ... 😬
from graphql-tools.
@helfer somehow I missed this notification! I'll open a PR today!
from graphql-tools.
Related Issues (20)
- @graphql-tools/mock does not work with Vitest HOT 5
- Deterministic (seeded) enum values
- Stitching: object field is null when all selections are delegated
- Http Executor encodes headers into query parameters which can leak Authorization headers
- Ability to get names of all the stitched queries in a middleware
- requireResolversToMatchSchema: 'warn' throws an error
- Support .astro file loading on graphql-tag-pluck HOT 1
- Troubles with connectionParams on subscriptions
- Adding content-type header is not supported when fetching schema
- Query does not provide a operation name as a property in the request body causing some server configurations to reject the request
- @graphql-tools/mock 9.0.1 causes panic: Internal errors HOT 2
- @graphql-tools/merge directive arguments compare should not require identical ordering HOT 1
- load babel options in `graphql-tag-pluck`
- [mock] relayStylePaginationMock sometimes returns an incorrect value for hasNextPage
- Batch execution throws an error when Array.prototype has additional property
- Federation @join__field requires parameter handling improvement
- filterSchema argumentFilter provides incorrect typeName
- globalGqlIdentifierName is inconsistently forced lowercase so doesn't work with mixed case identifiers HOT 1
- makeExecutableSchema fails if typeDefs includes a directive named toString
- Vite plugin a la jest-transform for GraphQL?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from graphql-tools.