Comments (6)
Hi @spdjudd! Thanks for submitting the question! This is something that Hera does not currently support but it's an addition that is not very complex, based on Argo's example: https://github.com/argoproj/argo-workflows/blob/master/examples/image-pull-secrets.yaml
Until Hera supports this, your use case probably necessitates something like:
w = Workflow(...)
setattr(w.spec, 'imagePullSecrets', [{'name': 'my-secret'}])
t = Task(..., image='my-private-image:latest')
w.add_task(t)
w.create()
from hera.
Wow, quick work on the PR - thanks! I tried your snippet above and found I had to use LocalObjectReference
instead of a dictionary to avoid serialisation errors, and this worked:
w = Workflow(...)
w.spec.set_attribute('imagePullSecrets', [LocalObjectReference(name='my-secret')])
t = Task(..., image='my-private-image:latest')
w.add_task(t)
w.create()
from hera.
Looks good and definitely solves my use case - thanks again!
from hera.
Hi Flaviu, thanks very much for the prompt and helpful response! I'll give that a try.
from hera.
Wow, quick work on the PR - thanks! I tried your snippet above and found I had to use
LocalObjectReference
instead of a dictionary to avoid serialisation errors, and this worked:
Yes, I noticed that when I started implementing it! Apologies for the error in the suggestion. Going to merge the PR soon if you agree it's the right approach and solves the use case you have! 🙂
from hera.
Added: #113
from hera.
Related Issues (20)
- New dag/steps decorators issues/inconsistencies
- Add argo linting for examples
- Add runner debug mode for extra logging HOT 1
- Artifact name should be optional for runner inputs
- Custom serialization for non-user types and non-serializable types for Hera runner HOT 1
- Cannot run script with tuple annotation in return type HOT 1
- Arguments do not build correctly when using a dict
- DAGs/Steps cannot be added to TemplateSets
- Validate Input/Output class for new decorator functions at build time
- Locally-runnable DAG breaks down for complex examples
- Support Literal types in script runner
- Mypy call-arg errors when using script decorator HOT 7
- Mypy misc error using new Workflow/TemplateSet decorators
- Difficult to use script functions in fully type-safe code
- Fields silently ignored in Pydantic I/O types HOT 1
- Cannot output a non-serialisable Artifact using Pydantic IO HOT 2
- Allow using Pydantic I/O in with-based code HOT 2
- Docs need some tidying up
- Add an end-to-end script runner example
- Input/Output artifacts are not supported in dag HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hera.