GithubHelp home page GithubHelp logo

Comments (5)

flaviuvadan avatar flaviuvadan commented on June 26, 2024 3

Hey @bobh66! There's a whole story to the initial effort to migrate. Here's the PR that attempted a second migration. The problem is that PyPi does not allow setting a dependency on a repo (as is currently the case with the new SDK). After a discussion with @terrytangyuan it's a bit unclear when the next release of Argo Workflows will take place, which inhibits the official release of the SDK. However, we've discussed using my fork of Argo Workflows, after it's up to date with the latest main branch of Argo Workflows, to create a release candidate as 6.0.0rc0, install that in Hera, and perform the migration. This will give us all the objects that are required, allow us to fix the problem you noticed with cron workflows, and allows us to just relock Hera to use the official SDK post publication to PyPi. Note that both 6.0.0rc0 and 6.0.0 would be officially released to PyPi, not to some projects that I am the sole owner of 🙂 I will try my best to get this done this upcoming weekend.

from hera.

flaviuvadan avatar flaviuvadan commented on June 26, 2024

Now that argoproj/argo-workflows#7363 was merged, we can start thinking about migrating to the new SDK when a new Argo release is performed.

from hera.

bobh66 avatar bobh66 commented on June 26, 2024

I could really use this change as I have a problem with the current SDK that won't be fixed. It validates the CronWorkflowStatus object that is returned in the create response for CronWorkflow, and it "fails" validation because the "active" attribute is None (since no cronjobs have run yet) which causes a KeyError exception even though the object was created successfully.

Is the new SDK available in pypi? I didn't see anything from a quick search. If you can point me in the right direction I'll see what I can put together.

from hera.

bobh66 avatar bobh66 commented on June 26, 2024

I should have looked further to see that you started it - let me know if I can be of any help.

from hera.

flaviuvadan avatar flaviuvadan commented on June 26, 2024

6.3.0rv2 was just released: https://pypi.org/project/argo-workflows/6.3.0rc2/ Will perform the migration this week and have a release candidate for Hera.

from hera.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.