rollout doesn't honor `canary.maxSurge` and `maxUnavailable` settings when `steps` filed is defined about argo-rollouts

[agaudreault]

Can you share the section of the documentation saying that maxSurge and maxUnavailable are used for TrafficRouting canary?

It does not seem implemented in here and the code is only using minPodsPerReplicaSet to decide how many canary pods should be scaled.

I think it would make sense to honor maxSurge and maxUnavailable fields, make sure minPodsPerReplicaSet is fulfilled before sending canary traffic, and gradually scale up until either the spec.replicas is used or we reach the configured replica weight.

  # The minimum number of pods that will be requested for each ReplicaSet
  # when using traffic routed canary. This is to ensure high availability
  # of each ReplicaSet. Defaults to 1. +optional
  minPodsPerReplicaSet: 2