Comments (4)
Hi, I've look through your repo and can't tell what primitives you are needing, which module/s in particular?
Regardless, I'm fine with this, but would put it behind a hazmat feature gate with some usage warning to expose internals.
from kyber.
Hey, thank your answer.
I would need the primitives of IND-CPA Kyber that are in reference::indcpa
. Namely, indcpa_keypair
, indcpa_enc
and indcpa_dec
.
Sure I agree this should not be exposed by default.
I forked your repo waiting for this change to be made upstream. I would propose a MR but it seems your editor leaves trailing spaces at the end of lines (while mine removes them on save) and that you are not using rustfmt
so it is a bit tedious to get clean diffs...
Would you consider sticking to the rustfmt
format or indicating how to format your code the way you do (I couldn't find it in your readme)?
Apart from exposing these primitives, I think I have spotted deprecated documentations which refer to KYBER_INDCPA_MSGBYTES
when no constant is declared with this name in the crate. As I understood, it should be replaced by KYBER_SYMBYTES
.
from kyber.
I have exposed the primitives in #36
from kyber.
Solved in #36
from kyber.
Related Issues (20)
- Use `aes` crate? HOT 2
- `std` as a default feature
- Inefficient KEX struct
- Get criterion v0.5 working
- Inconsistent between C and Rust implementations HOT 4
- Potential security vulnerability: non-constant-time usages of division HOT 4
- Release CI github action HOT 1
- Add rustfmt.toml file HOT 1
- API Redesign & Ergonomics HOT 1
- memfd support HOT 1
- v0.5.0 not on master HOT 1
- Kyber does not allow explicit rejection HOT 7
- fips202 keccak_absorb does not absorb properly HOT 1
- gen_matrix is incorrect HOT 2
- MacOS: fails benchmarks HOT 10
- How to send encrypted public key to the server in Mutually Authenticated Key Exchange? HOT 2
- Kyber not compiling with React
- NSA suggestions HOT 2
- Error compiling pqc_kyber library in rust program`(panic_handler)` HOT 3
- Massive amounts of `clippy` warnings HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kyber.