GithubHelp home page GithubHelp logo

Expose CPA primitives about kyber HOT 4 CLOSED

argyle-software avatar argyle-software commented on June 15, 2024
Expose CPA primitives

from kyber.

Comments (4)

mberry avatar mberry commented on June 15, 2024

Hi, I've look through your repo and can't tell what primitives you are needing, which module/s in particular?

Regardless, I'm fine with this, but would put it behind a hazmat feature gate with some usage warning to expose internals.

from kyber.

tbrezot avatar tbrezot commented on June 15, 2024

Hey, thank your answer.

I would need the primitives of IND-CPA Kyber that are in reference::indcpa. Namely, indcpa_keypair, indcpa_enc and indcpa_dec.

Sure I agree this should not be exposed by default.

I forked your repo waiting for this change to be made upstream. I would propose a MR but it seems your editor leaves trailing spaces at the end of lines (while mine removes them on save) and that you are not using rustfmt so it is a bit tedious to get clean diffs...

Would you consider sticking to the rustfmt format or indicating how to format your code the way you do (I couldn't find it in your readme)?

Apart from exposing these primitives, I think I have spotted deprecated documentations which refer to KYBER_INDCPA_MSGBYTES when no constant is declared with this name in the crate. As I understood, it should be replaced by KYBER_SYMBYTES.

from kyber.

tbrezot avatar tbrezot commented on June 15, 2024

I have exposed the primitives in #36

from kyber.

tbrezot avatar tbrezot commented on June 15, 2024

Solved in #36

from kyber.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.