handshake failure in downloading from https://ftp.mozilla.org/; error download not saved with --save-session about aria2

[nmaier]

Culprit: https://github.com/tatsuhiro-t/aria2/blob/0bcbd947b47d8f3af6c04508f7d493edc901dfdc/src/LibgnutlsTLSSession.cc#L74

aria2 disables TLS 1.1 for whatever reason. However, gnutls will still send a client_hello annoucing the not-disabled TLS 1.2 (0x303). ftp.mozilla.org hence responds with a server_hello version of TLS 1.1 (0x303) which aria2/gnutls then refuses because it was specifically disabled.

I guess the line above should be dropped, of if there was a valid reason to include it, should be expanded to also disable TLS 1.2, so that the client_hello will announce max TLS 1.0.

[tatsuhiro-t]

Thank you for the valuable information. Enabled TLS 1.1 just now. I experienced gnuttls's buggy behavior for TLS1.1 in the past, but it was long time ago and I didn't remember the error message.

[tatsuhiro-t]

Can we close this now?

[multiSnow]

what about the second part of this issue, or I should just creat it as a new issue?

[tatsuhiro-t]

Sorry, I completely missed it.
If download was failed after trying all available URIs, aria2 does not save it, because restarting such download will also fail. Do you think we should save such download with failed URIs?

[multiSnow]

hmm...
If a temporary wrong DNS record received or temporary site down (e.g. site maintance), and of cource it causes download failed, it would not be saved.
But it is a temporary wrong, would be fixed in a short time.
I should re-get the URIs of these download or they are just lost.
Of cource I can re-get it by hands, but don't you think it would be more convenient if they are saved at somewhere, especially they are not only one or ten URIs?

[tatsuhiro-t]

OK, save error downloads with all failed URIs then.

[tatsuhiro-t]

Fix committed fde376e

[tatsuhiro-t]

@multiSnow Could you check that the above commit works for you?

[multiSnow]

It works.

[tatsuhiro-t]

Thanks. Let's close the issue.