GithubHelp home page GithubHelp logo

reserved identifier violation about packcc HOT 15 CLOSED

arithy avatar arithy commented on July 17, 2024
reserved identifier violation

from packcc.

Comments (15)

arithy avatar arithy commented on July 17, 2024 1

@elfring, @MaxBarraclough,
I'm going to close this issue because of the following reasons:

  • PackCC generates a C source code in a .c file (not in a file with the C++ extension such as .cpp).
  • PackCC generates a C header file that can be included from C++ source files with no problem.
  • I strongly disagree too vast the identifier pattern that POSIX claims to reserve.

If you have any objection against closing this issue, let me know by the end of this month (Aug. 2022).

from packcc.

arithy avatar arithy commented on July 17, 2024

Thank you for your advice.
I replaced every double underscore __ with a single underscore if it is in an identifier that consists of uppercase letters and underscores.
Please check out the branch 'develop'.

from packcc.

elfring avatar elfring commented on July 17, 2024

Thanks for your renaming of affected identifiers.

🔮 Can a name selection trigger any corresponding software development concerns?

from packcc.

elfring avatar elfring commented on July 17, 2024

How do you think about to rename also functions?

from packcc.

arithy avatar arithy commented on July 17, 2024

How do you think about to rename also functions?

I don't want to rename them anymore.
I determined the function naming convention like 'class name'__'method name' to distinguish it plainly from other word delimiters '_'.

Can a name selection trigger any corresponding software development concerns?

Sorry, I couldn't understand what you mean.
Could you express it more simply?

from packcc.

elfring avatar elfring commented on July 17, 2024

I don't want to rename them anymore.

This implementation detail can be fine according to the naming convention for the programming language “C”.
Can anybody get concerned about remaining risks for undefined behaviour if contents from C files will be treated as C++ source code anyhow?

Could you express it more simply?

Is there a possibility that an identifier will be constructed (together with the prefix “PCC_INCLUDED_”) that does not result in an acceptable include guard?

from packcc.

MaxBarraclough avatar MaxBarraclough commented on July 17, 2024

Identifiers ending with "_t" are also reserved in C++. I see many instances of this in packcc, even in the develop branch. https://stackoverflow.com/a/228797/

I also see "__pcc_in", "__pcc_out", and "__pcc_ctx" in the develop branch, all of which C++ considers to be reserved identifiers due to the leading double underscores.

As @elfring says, C++ has stricter rules than C regarding which identifiers are considered reserved.

from packcc.

audinue avatar audinue commented on July 17, 2024

Is this a parser generator for C or C++?

from packcc.

arithy avatar arithy commented on July 17, 2024

Just for C.
You can use it with a C++ compiler, but I don't support such usage.

from packcc.

audinue avatar audinue commented on July 17, 2024

Why @elfring asked you to comply with C++ language standard then?

from packcc.

arithy avatar arithy commented on July 17, 2024

Just because @elfring wanted to use PackCC with C++, I think.
I accepted a part of @elfring's suggestion since I thought it had better comply with C++ standard as much as possible.
Anyway, I can close this issue if I strictly stand on the specification: just for C.

from packcc.

elfring avatar elfring commented on July 17, 2024

💭 I became curious if interests could grow further for involved standard compliance aspects.

from packcc.

audinue avatar audinue commented on July 17, 2024

thought_balloon I became curious if interests could grow further for involved standard compliance aspects.

Why not putting some ads on Youtube instead of violating the scope of this project?

from packcc.

elfring avatar elfring commented on July 17, 2024

Some development concerns can be tackled together for the programming languages “C” and “C++”, can't they?

from packcc.

arithy avatar arithy commented on July 17, 2024

I became curious if interests could grow further for involved standard compliance aspects.

It might be just your impression, and isn't persuasive.

Some development concerns can be tackled together for the programming languages “C” and “C++”, can't they?

I never deny using C and C++ together.
I already wrote "PackCC generates a C header file that can be included from C++ source files with no problem".
The generated C code is callable from C++ codes.

from packcc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.